Skip to content

Conversation

@tom-englert
Copy link

Fix for NuGet/Home#304 (replaces #19)

@tom-englert
Copy link
Author

@yishaigalatzer Any idea when this will be released? I'm waiting for this fix!

@yishaigalatzer
Copy link
Contributor

Will merge this week. Released within a few weeks

Sent from my Windows Phone


From: Tom Englertmailto:notifications@github.com
Sent: ‎11/‎8/‎2015 7:52 AM
To: NuGet/NuGet2mailto:NuGet2@noreply.github.com
Cc: Yishai Galatzermailto:yigalatz@microsoft.com
Subject: Re: [NuGet2] Add missing source files referenced by PDB. (#23)

@yishaigalatzerhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fyishaigalatzer&data=01%7c01%7cyigalatz%40microsoft.com%7cfb4097f6c6204d0bb69808d2e85488d7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=gZNVY5%2bXQu%2fKpssRJNNDjj0pztfuqKvEubGv%2buc6%2fmY%3d Any idea when this will be released? I'm waiting for this fix!


Reply to this email directly or view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fNuGet%2fNuGet2%2fpull%2f23%23issuecomment-154834812&data=01%7c01%7cyigalatz%40microsoft.com%7cfb4097f6c6204d0bb69808d2e85488d7%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=x1RlieqSiQu8dOQ3Zss2lMPN3XF1XXGgo5KuBwFFkoA%3d.

@MeniZalzman
Copy link
Contributor

@tom-englert i tried validating your changes and it did not work for me, After merging your changes to my own branch and re-based it with 2.10 then fixed all the FXCop errors i tried packing WPF project and the generated source files are still missing from the package, Can you please add tests that validate this feature or send me a project that i can validate that?

https://github.com/nuget/nuget2/tree/MergingTomsPR

@tom-englert
Copy link
Author

@MeniZalzman I have tested this with https://tomstoolbox.codeplex.com/SourceControl/latest.
However this fix does not guarantee that all generated source files are part of the package; only source files that are referenced by the pdbs are added, so the symbol package can be uploaded to symbolsource.org

@ghost ghost removed the cla-already-signed label Dec 6, 2017
@ghost ghost deleted a comment from dnfclas Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants