State Types - NodeState struct definitions

[m-005]

Part 3 of the Foundation stage for objects-node daemon.

Changes

Adds state type definitions for persistent node state:

• NodeState - Persistent state with node keypair and optional identity
  • Uses SecretKey from objects-transport (Iroh Ed25519 key)
  • Optional IdentityInfo for registered OBJECTS identities
• IdentityInfo - RFC-001 identity linking:
  • Identity ID (obj_ + base58 hash)
  • Registered handle
  • 8-byte nonce for ID derivation
  • Signer type (Passkey or Wallet)

Security

Comprehensive documentation on security requirements:

• State files must use 600 permissions (owner read/write only)
• Node key must be kept secure and never committed to version control
• Supports anonymous mode (no identity) for nodes that don't publish assets

Testing

• Serialization round-trip tests
• Identity persistence tests
• Both Passkey and Wallet signer types validated

Part of the Foundation stage (3/4). Builds on: #47. Next: State Persistence (#37).

[claude]

Code Review

Found 2 issues:

Issue 1: CLAUDE.md compliance - Use shared test utility

File: bins/objects-node/src/state.rs (lines 82, 105)

The tests should use objects_test_utils::transport::secret_key() instead of calling SecretKey::generate(&mut rand::rng()) directly.

Per CLAUDE.md:

Use shared test utilities from objects-test-utils instead of duplicating helpers.

• transport - Endpoint and network config factories

The transport::secret_key() utility exists for exactly this purpose.

Suggested fix:

let node_key = transport::secret_key();

---

Issue 2: Missing signer_public_key field in IdentityInfo

File: bins/objects-node/src/state.rs (lines 50-73)

The IdentityInfo struct stores the nonce field with documentation stating it is "required for verification of the identity ID" (line 65), but is missing the signer_public_key field which is also required.

Per RFC-001 and IdentityId::derive(), identity IDs are derived from:

identity_id = "obj_" || base58(truncate(sha256(signer_public_key || nonce), 15))

Without the signer_public_key, it is impossible to verify the identity ID derivation. The verify_id_derivation() function requires both the public key and nonce to re-derive and verify the identity ID.

Suggested fix:
Add a signer_public_key: [u8; 33] field to the IdentityInfo struct to enable identity ID verification.

[claude]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.