[18.0][MIG] auth_jwt: Migration to 18.0 #752

dnplkndll · 2025-01-16T22:59:40Z

No description provided.

lmignon · 2025-01-17T07:55:49Z

/ocabot migration auth_jwt

sbidoul · 2025-01-18T14:15:23Z

Thanks for working on this. Could you re-do the migration based on the merged 17.0 version? Your migration commit is ok, but the history of the 17.0 branch you started with is a bit messy and has been cleaned-up since.

kobros-tech

@lmignon
@sbidoul

could you review this PR, we have merged migration for 17.0 and we can migrate it for 18.0

ChuwenSun

Looks good to me.

dnplkndll · 2025-02-15T02:05:30Z

Thanks for working on this. Could you re-do the migration based on the merged 17.0 version? Your migration commit is ok, but the history of the 17.0 branch you started with is a bit messy and has been cleaned-up since.

@sbidoul rebased and squashed the bot commits.

OCA-git-bot · 2025-02-15T03:50:44Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dnplkndll · 2025-03-19T18:51:27Z

any update requested or this should be ready to merge

kobros-tech · 2025-03-20T13:16:33Z

@lmignon
@sbidoul

LGTM!

sbidoul · 2025-03-20T15:15:42Z

I think there is a problem with the _authenticate override in ir_http.py. The upstream method has changed and the arguments don't match anymore.

I'm surprised this would work correctly.

I'd say we should rather override _authenticate_explicit but I'm not sure.

sbidoul

As mentioned in my previous comment.

sbidoul · 2025-03-20T18:46:07Z

Ah, can you also migrate auth_jwt_demo in this same PR because that's where all the tests are.

kobros-tech · 2025-04-01T17:11:54Z

Ah, can you also migrate auth_jwt_demo in this same PR because that's where all the tests are.

@sbidoul
Hi auth_jwt_demo is open now for review, #780

sbidoul · 2025-05-15T16:22:21Z

I commented on the auth_jwt_demo migration.

Have had a chance to look at #752 (comment) ?

Distinguish errors that lead to a 401 from internal configuration errors.

Extract _parse_bearer_authorization function for easier reuse by fastapi_auth_jwt

Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/es/

Currently translated at 89.0% (57 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/

Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-17.0/server-auth-17.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_jwt/

kobros-tech · 2025-08-26T02:29:56Z

@sbidoul

I think it is very ready now?

yvaucher · 2025-08-26T06:58:36Z

/ocabot merge nobump

OCA-git-bot · 2025-08-26T06:58:43Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-752-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot · 2025-08-26T07:04:23Z

Congratulations, your PR was merged at 5afea9a. Thanks a lot for contributing to OCA. ❤️

dnplkndll changed the title ~~[18.0][MIG] auth_jwt~~ [18.0][MIG] auth_jwt: Migration 18.0 Jan 16, 2025

dnplkndll changed the title ~~[18.0][MIG] auth_jwt: Migration 18.0~~ [18.0][MIG] auth_jwt: Migration to 18.0 Jan 16, 2025

dnplkndll mentioned this pull request Jan 16, 2025

[18.0][MIG] fastapi_auth_jwt: Migration to 18.0 OCA/rest-framework#490

Open

2 tasks

OCA-git-bot added this to the 18.0 milestone Jan 17, 2025

OCA-git-bot mentioned this pull request Jan 17, 2025

Migration to version 18.0 #698

Open

22 tasks

dnplkndll mentioned this pull request Jan 17, 2025

[18.0][IMP] auth_jwt: allow more authorization options over aud #753

Open

dnplkndll force-pushed the 18.0-mig-auth_jwt branch from 0068509 to 20c9df5 Compare January 18, 2025 17:35

kobros-tech approved these changes Jan 20, 2025

View reviewed changes

dnplkndll force-pushed the 18.0-mig-auth_jwt branch from 20c9df5 to 0152839 Compare January 23, 2025 01:25

ChuwenSun approved these changes Feb 3, 2025

View reviewed changes

OCA-git-bot added the approved label Feb 3, 2025

dnplkndll force-pushed the 18.0-mig-auth_jwt branch 2 times, most recently from d5e8550 to bda753a Compare February 15, 2025 02:02

OCA-git-bot added the ready to merge label Feb 15, 2025

sbidoul requested changes Mar 20, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Mar 20, 2025

kobros-tech force-pushed the 18.0-mig-auth_jwt branch from bda753a to 7c58f89 Compare April 1, 2025 05:00

kobros-tech mentioned this pull request Apr 1, 2025

[MIG] auth_jwt_demo: Migration to 18.0 #780

Closed

1 task

kobros-tech mentioned this pull request Apr 2, 2025

[MIG] fastapi_auth_jwt_demo: Migration to 18.0 OCA/rest-framework#516

Open

3 tasks

sbidoul and others added 21 commits August 25, 2025 04:37

auth_jwt: clarify exceptions

4a06a42

Distinguish errors that lead to a 401 from internal configuration errors.

auth_jwt: minor refactoring

356bdf9

[IMP] auth_jwt: refactor

c19e1a9

Extract _parse_bearer_authorization function for easier reuse by fastapi_auth_jwt

[FIX] auth_jwt: don't use public mode if a cookie is present

5c7ce82

[IMP] auth_jwt: check cookie_name is present in cookie mode

3adb205

[UPD] Update auth_jwt.pot

c1ad5a6

[UPD] README.rst

55f6c40

auth_jwt 16.0.1.1.0

b4ba8b0

Added translation using Weblate (Spanish)

d468520

Translated using Weblate (Spanish)

1d929b4

Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/es/

[UPD] README.rst

f0fa200

Added translation using Weblate (Italian)

0bc67e5

Translated using Weblate (Italian)

b9ad174

Currently translated at 89.0% (57 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/

Translated using Weblate (Italian)

c75c67f

Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/

Translated using Weblate (Italian)

4e5a8d6

Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/

[MIG] auth_jwt: Migration to 17.0

208f80e

[UPD] Update auth_jwt.pot

88c5a1f

[BOT] post-merge updates

0700ed5

Update translation files

222c104

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-17.0/server-auth-17.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_jwt/

[IMP] auth_jwt: pre-commit auto fixes

a888c3c

[MIG] auth_jwt: Migration to 18.0

936aa6a

kobros-tech force-pushed the 18.0-mig-auth_jwt branch from 7c58f89 to 936aa6a Compare August 25, 2025 01:46

OCA-git-bot added the bot is merging ⏳ label Aug 26, 2025

OCA-git-bot merged commit 8f93c1c into OCA:18.0 Aug 26, 2025
7 of 9 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 26, 2025

Uh oh!

[18.0][MIG] auth_jwt: Migration to 18.0 #752

[18.0][MIG] auth_jwt: Migration to 18.0 #752

Uh oh!

Conversation

dnplkndll commented Jan 16, 2025

Uh oh!

lmignon commented Jan 17, 2025

Uh oh!

sbidoul commented Jan 18, 2025

Uh oh!

kobros-tech left a comment

Choose a reason for hiding this comment

Uh oh!

ChuwenSun left a comment

Choose a reason for hiding this comment

Uh oh!

dnplkndll commented Feb 15, 2025

Uh oh!

OCA-git-bot commented Feb 15, 2025

Uh oh!

dnplkndll commented Mar 19, 2025

Uh oh!

kobros-tech commented Mar 20, 2025

Uh oh!

sbidoul commented Mar 20, 2025

Uh oh!

sbidoul left a comment

Choose a reason for hiding this comment

Uh oh!

sbidoul commented Mar 20, 2025

Uh oh!

kobros-tech commented Apr 1, 2025

Uh oh!

sbidoul commented May 15, 2025

Uh oh!

kobros-tech commented Aug 26, 2025

Uh oh!

yvaucher commented Aug 26, 2025

Uh oh!

OCA-git-bot commented Aug 26, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Aug 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants