You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here's the initial work on extending generateDS' GdsCollector to offer more helpful help messages.
This replaces the buildin parse/parseString methods with variants that know about the filename (and passes it on to OcrdGdsCollector.
OcrdGdsCollector should probably have the same interface, i.e. inherit from ValidationReport (which needs to support an alias add_message -> add_error).
Now that the foundations are here, we can discuss what kind of information should be captured and how messages should be formatted.
Now that the foundations are here, we can discuss what kind of information should be captured and how messages should be formatted.
We discussed this briefly in yesterday's tech call: now that we have a ValidationReport along with the PAGE object, which makes validation errors actionable (without the need to repeat validation in dedicated tools/steps), we could add hooks to to_xml for post-processing (e.g. coordinate repair). As a first step, this could be setting negative points to zero automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the initial work on extending generateDS' GdsCollector to offer more helpful help messages.
This replaces the buildin
parse/parseStringmethods with variants that know about the filename (and passes it on to OcrdGdsCollector.OcrdGdsCollector should probably have the same interface, i.e. inherit from ValidationReport (which needs to support an alias
add_message->add_error).Now that the foundations are here, we can discuss what kind of information should be captured and how messages should be formatted.