Skip to content

Comments

Fix VideoCacheThread::isReady() when near the max frame of a timeline#1036

Merged
jonoomph merged 1 commit intodevelopfrom
timeline-playback-length
Feb 13, 2026
Merged

Fix VideoCacheThread::isReady() when near the max frame of a timeline#1036
jonoomph merged 1 commit intodevelopfrom
timeline-playback-length

Conversation

@jonoomph
Copy link
Member

Fix VideoCacheThread::isReady() so preroll readiness is clamped by frames actually available to the timeline boundary (end/start), preventing playback from stalling in PLAY near the end.

Also, add regression coverage in tests/VideoCacheThread.cpp (isReady: clamps preroll requirement at timeline boundaries) for forward-near-end and backward-near-start cases.

…y frames actually available to the timeline boundary (end/start), preventing playback from stalling in PLAY near the end.

  - Add regression coverage in tests/VideoCacheThread.cpp (isReady: clamps preroll requirement at timeline boundaries) for forward-near-end and backward-near-start cases.
@jonoomph
Copy link
Member Author

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.69%. Comparing base (57c1fb2) to head (fb41a3c).

Files with missing lines Patch % Lines
src/Qt/VideoCacheThread.cpp 80.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1036      +/-   ##
===========================================
+ Coverage    59.59%   59.69%   +0.09%     
===========================================
  Files          206      206              
  Lines        20511    20567      +56     
===========================================
+ Hits         12224    12277      +53     
- Misses        8287     8290       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonoomph jonoomph merged commit 8c4db9a into develop Feb 13, 2026
13 checks passed
@jonoomph jonoomph deleted the timeline-playback-length branch February 13, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant