Skip to content

🔄 synced file(s) with OrrisTech/.github#3

Merged
iamzifei merged 1 commit intomainfrom
repo-sync/github/default
Feb 20, 2026
Merged

🔄 synced file(s) with OrrisTech/.github#3
iamzifei merged 1 commit intomainfrom
repo-sync/github/default

Conversation

@iamzifei
Copy link
Contributor

@iamzifei iamzifei commented Feb 20, 2026

synced local file(s) with OrrisTech/.github.

This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.

Changed files
  • synced local .github/workflows/ci.yml with remote sync/.github/workflows/ci.yml

This PR was created automatically by the repo-file-sync-action workflow run #22211856352

Copilot AI review requested due to automatic review settings February 20, 2026 04:54
@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agent-otp-website Error Error Feb 20, 2026 4:54am

Request Review

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR automatically syncs CI workflow configuration from the organization's central .github repository to standardize CI practices across all OrrisTech repositories. The changes make lint/type-checking and security audit jobs advisory-only, allowing the CI pipeline to pass even when these checks fail.

Changes:

  • Added continue-on-error: true to the lint-typecheck job with explanatory comments indicating this is temporary until lint errors are resolved
  • Removed the needs: [lint-typecheck] dependency from the build job, allowing it to run in parallel with linting rather than waiting for lint checks to complete
  • Added continue-on-error: true to the security audit job to make it advisory-only

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -33,12 +36,13 @@ jobs:

build:
name: Build
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting continue-on-error: true combined with removing needs: [lint-typecheck] from the build job significantly weakens CI enforcement of code quality standards. The CI pipeline will now always pass even if there are linting or type-checking errors, and the build won't wait for lint checks to complete.

While the comment indicates this is temporary ("Remove continue-on-error once repo lint errors are resolved"), this approach allows technical debt to accumulate and makes it easy to forget to address underlying issues. Consider these alternatives:

  1. Fix existing lint errors in this repository first, then apply this sync
  2. Use GitHub's required status checks to make lint-typecheck "required" but allow bypassing with admin approval
  3. Add a time-bound issue or deadline to resolve lint errors and remove continue-on-error
  4. Keep the needs dependency to at least maintain the logical job order even if errors are allowed
Suggested change
name: Build
name: Build
needs: [lint-typecheck]

Copilot uses AI. Check for mistakes.
@iamzifei iamzifei merged commit b19d61e into main Feb 20, 2026
1 of 2 checks passed
@iamzifei iamzifei deleted the repo-sync/github/default branch February 20, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments