Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
28ab455 to
b3046af
Compare
There was a problem hiding this comment.
Pull request overview
This PR automatically syncs CI workflow configuration from the organization's central .github repository to standardize CI practices across all OrrisTech repositories. The changes make lint/type-checking and security audit jobs advisory-only, allowing the CI pipeline to pass even when these checks fail.
Changes:
- Added
continue-on-error: trueto the lint-typecheck job with explanatory comments indicating this is temporary until lint errors are resolved - Removed the
needs: [lint-typecheck]dependency from the build job, allowing it to run in parallel with linting rather than waiting for lint checks to complete - Added
continue-on-error: trueto the security audit job to make it advisory-only
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -33,12 +36,13 @@ jobs: | |||
|
|
|||
| build: | |||
| name: Build | |||
There was a problem hiding this comment.
Setting continue-on-error: true combined with removing needs: [lint-typecheck] from the build job significantly weakens CI enforcement of code quality standards. The CI pipeline will now always pass even if there are linting or type-checking errors, and the build won't wait for lint checks to complete.
While the comment indicates this is temporary ("Remove continue-on-error once repo lint errors are resolved"), this approach allows technical debt to accumulate and makes it easy to forget to address underlying issues. Consider these alternatives:
- Fix existing lint errors in this repository first, then apply this sync
- Use GitHub's required status checks to make lint-typecheck "required" but allow bypassing with admin approval
- Add a time-bound issue or deadline to resolve lint errors and remove continue-on-error
- Keep the
needsdependency to at least maintain the logical job order even if errors are allowed
| name: Build | |
| name: Build | |
| needs: [lint-typecheck] |
synced local file(s) with OrrisTech/.github.
This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.
Changed files
.github/workflows/ci.ymlwith remotesync/.github/workflows/ci.ymlThis PR was created automatically by the repo-file-sync-action workflow run #22211856352