-
Notifications
You must be signed in to change notification settings - Fork 0
🔄 synced file(s) with OrrisTech/.github #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,8 +24,7 @@ jobs: | |
| lint-typecheck: | ||
| name: Lint & Type Check | ||
| # Advisory only — does not block build or other jobs. | ||
| # Remove continue-on-error once repo lint errors are resolved. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. | ||
| uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main | ||
| secrets: inherit | ||
|
|
||
|
|
@@ -42,7 +41,7 @@ jobs: | |
| security: | ||
| name: Security Audit | ||
| # Advisory only — does not block other jobs. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. | ||
| uses: OrrisTech/.github/.github/workflows/ci-security.yml@main | ||
|
Comment on lines
43
to
45
|
||
| secrets: inherit | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments are misleading now that
continue-on-error: truewas removed. Even withoutneeds:, a failing job will still make the overall workflow conclude as failed (and can block PR merge via required status checks). Either re-addcontinue-on-error: trueto keep this advisory, or update/remove the “Advisory only” / “won't block CI” wording to reflect the new enforced behavior.