Skip to content

🔄 synced file(s) with OrrisTech/.github#2

Merged
iamzifei merged 1 commit intomainfrom
repo-sync/github/default
Feb 20, 2026
Merged

🔄 synced file(s) with OrrisTech/.github#2
iamzifei merged 1 commit intomainfrom
repo-sync/github/default

Conversation

@iamzifei
Copy link
Contributor

@iamzifei iamzifei commented Feb 20, 2026

synced local file(s) with OrrisTech/.github.

This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.

Changed files
  • synced local .github/workflows/ci.yml with remote sync/.github/workflows/ci.yml

This PR was created automatically by the repo-file-sync-action workflow run #22211856352

Copilot AI review requested due to automatic review settings February 20, 2026 04:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s thin CI caller workflow to match the organization-standard workflow in OrrisTech/.github, primarily changing how lint/typecheck and security audit failures affect the overall CI result.

Changes:

  • Make lint-typecheck job advisory by allowing it to fail without failing the workflow (continue-on-error: true).
  • Make security audit job advisory by allowing it to fail without failing the workflow (continue-on-error: true).
  • Remove the build job’s dependency on lint-typecheck, allowing build to run independently.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +44 to +45
# Advisory only — does not block other jobs.
continue-on-error: true
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking the Security Audit job as continue-on-error: true means the workflow will succeed even when the security audit fails (including on pushes to main/master). This significantly reduces the value of the audit; consider making failures blocking at least on default-branch pushes, or gating continue-on-error to PRs only.

Suggested change
# Advisory only — does not block other jobs.
continue-on-error: true
# Advisory only on pull requests — blocks on pushes to main/master.
continue-on-error: ${{ github.event_name == 'pull_request' }}

Copilot uses AI. Check for mistakes.
Comment on lines +26 to +28
# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue-on-error: true makes lint/typecheck failures non-blocking for both PRs and pushes to main/master. If the intent is only to avoid blocking PRs while existing lint debt is worked down, consider making this conditional (e.g., allow failures on pull_request but enforce on push to default branches) so main stays protected.

Suggested change
# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
# Advisory only for pull requests — does not block build or other jobs.
# Remove or tighten continue-on-error once repo lint errors are resolved.
continue-on-error: ${{ github.event_name == 'pull_request' }}

Copilot uses AI. Check for mistakes.
@iamzifei iamzifei merged commit 94c7e98 into main Feb 20, 2026
@iamzifei iamzifei deleted the repo-sync/github/default branch February 20, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments