Skip to content

🔄 synced file(s) with OrrisTech/.github #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamzifei merged 1 commit into from
Feb 20, 2026
+5 −1
Merged

🔄 synced file(s) with OrrisTech/.github #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ concurrency:
jobs:
lint-typecheck:
name: Lint & Type Check
# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
Comment on lines +26 to +28
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue-on-error: true makes lint/typecheck failures non-blocking for both PRs and pushes to main/master. If the intent is only to avoid blocking PRs while existing lint debt is worked down, consider making this conditional (e.g., allow failures on pull_request but enforce on push to default branches) so main stays protected.

Suggested change
# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
# Advisory only for pull requests — does not block build or other jobs.
# Remove or tighten continue-on-error once repo lint errors are resolved.
continue-on-error: ${{ github.event_name == 'pull_request' }}

Copilot uses AI. Check for mistakes.
uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main
secrets: inherit

Expand All @@ -33,12 +36,13 @@ jobs:

build:
name: Build
needs: [lint-typecheck]
uses: OrrisTech/.github/.github/workflows/ci-build.yml@main
secrets: inherit

security:
name: Security Audit
# Advisory only — does not block other jobs.
continue-on-error: true
Comment on lines +44 to +45
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking the Security Audit job as continue-on-error: true means the workflow will succeed even when the security audit fails (including on pushes to main/master). This significantly reduces the value of the audit; consider making failures blocking at least on default-branch pushes, or gating continue-on-error to PRs only.

Suggested change
# Advisory only — does not block other jobs.
continue-on-error: true
# Advisory only on pull requests — blocks on pushes to main/master.
continue-on-error: ${{ github.event_name == 'pull_request' }}

Copilot uses AI. Check for mistakes.
uses: OrrisTech/.github/.github/workflows/ci-security.yml@main
secrets: inherit

Expand Down