Conversation
c01d258 to
978709d
Compare
React Doctor ReportClick to expand results
|
There was a problem hiding this comment.
Pull request overview
Syncs this repo’s CI caller workflow with the organization-standard workflow from OrrisTech/.github, updating how lint/typecheck and security jobs are treated in CI.
Changes:
- Removed
continue-on-error: truefromlint-typecheckandsecurityjobs. - Updated inline comments describing those jobs’ blocking/advisory behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Security Audit | ||
| # Advisory only — does not block other jobs. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. |
There was a problem hiding this comment.
Same issue here: removing continue-on-error: true means a security audit failure will fail the overall workflow run. The “advisory only / won’t block” comments should either be corrected, or continue-on-error: true should be restored if this job is intended to be non-blocking.
| # No "needs:" from other jobs, so failures here won't block CI. | |
| # No "needs:" from other jobs, so failures here won't block CI. | |
| continue-on-error: true |
| # Advisory only — does not block build or other jobs. | ||
| # Remove continue-on-error once repo lint errors are resolved. | ||
| continue-on-error: true | ||
| # No "needs:" from other jobs, so failures here won't block CI. | ||
| uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main |
There was a problem hiding this comment.
These comments are inaccurate: even without needs, a failing job still makes the workflow run fail (and will block merges if this workflow is a required check). If the intent is truly “advisory only”, re-add continue-on-error: true; otherwise update/remove the “Advisory only / won’t block CI” wording to reflect that failures will fail the CI check.
synced local file(s) with OrrisTech/.github.
This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.
Changed files
.github/workflows/ci.ymlwith remotesync/.github/workflows/ci.ymlThis PR was created automatically by the repo-file-sync-action workflow run #22212195514