Skip to content

🔄 synced file(s) with OrrisTech/.github#3

Merged
iamzifei merged 1 commit intomainfrom
repo-sync/github/default
Feb 20, 2026
Merged

🔄 synced file(s) with OrrisTech/.github#3
iamzifei merged 1 commit intomainfrom
repo-sync/github/default

Conversation

@iamzifei
Copy link
Contributor

@iamzifei iamzifei commented Feb 20, 2026

synced local file(s) with OrrisTech/.github.

This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.

Changed files
  • synced local .github/workflows/ci.yml with remote sync/.github/workflows/ci.yml

This PR was created automatically by the repo-file-sync-action workflow run #22212195514

Copilot AI review requested due to automatic review settings February 20, 2026 05:11
@github-actions
Copy link
Contributor

React Doctor Report

Click to expand results
npm warn exec The following package was not found and will be installed: react-doctor@0.0.28
react-doctor v0.0.28

�[2mScanning /home/runner/work/clawface/clawface...�[22m


�[31mSomething went wrong. Please check the error below for more details.�[39m
�[31mIf the problem persists, please open an issue on GitHub.�[39m
�[31m�[39m
�[31mNo React dependency found in package.json�[39m

Powered by react-doctor

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs this repo’s CI caller workflow with the organization-standard workflow from OrrisTech/.github, updating how lint/typecheck and security jobs are treated in CI.

Changes:

  • Removed continue-on-error: true from lint-typecheck and security jobs.
  • Updated inline comments describing those jobs’ blocking/advisory behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

name: Security Audit
# Advisory only — does not block other jobs.
continue-on-error: true
# No "needs:" from other jobs, so failures here won't block CI.
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here: removing continue-on-error: true means a security audit failure will fail the overall workflow run. The “advisory only / won’t block” comments should either be corrected, or continue-on-error: true should be restored if this job is intended to be non-blocking.

Suggested change
# No "needs:" from other jobs, so failures here won't block CI.
# No "needs:" from other jobs, so failures here won't block CI.
continue-on-error: true

Copilot uses AI. Check for mistakes.
Comment on lines 26 to 28
# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
# No "needs:" from other jobs, so failures here won't block CI.
uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are inaccurate: even without needs, a failing job still makes the workflow run fail (and will block merges if this workflow is a required check). If the intent is truly “advisory only”, re-add continue-on-error: true; otherwise update/remove the “Advisory only / won’t block CI” wording to reflect that failures will fail the CI check.

Copilot uses AI. Check for mistakes.
@iamzifei iamzifei merged commit 986e917 into main Feb 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments