Conversation
2e94580 to
aae7342
Compare
There was a problem hiding this comment.
Pull request overview
This PR syncs the CI workflow file from the organization's central .github repository. The changes adjust the CI pipeline to make lint and security checks advisory-only, allowing builds and tests to proceed regardless of their outcomes.
Changes:
- Added
continue-on-error: trueto lint-typecheck and security jobs to make them non-blocking - Removed the dependency of the build job on lint-typecheck, allowing parallel execution
- Added explanatory comments documenting the advisory nature of these jobs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -33,12 +36,13 @@ jobs: | |||
|
|
|||
| build: | |||
| name: Build | |||
There was a problem hiding this comment.
The removal of the needs: [lint-typecheck] dependency means the build job will now run in parallel with lint-typecheck instead of waiting for it to complete. Since lint-typecheck now has continue-on-error: true, this change makes sense to avoid blocking the build. However, this means builds could proceed even if lint checks are still running or have failed.
Consider whether this is the intended behavior for your CI pipeline. If you want to ensure builds only happen after linting completes (even if it fails), you should keep the needs dependency but rely on continue-on-error: true to prevent blocking.
| name: Build | |
| name: Build | |
| needs: [lint-typecheck] |
synced local file(s) with OrrisTech/.github.
This PR was automatically created by the org file sync workflow. It syncs the latest org standard files from the .github repo. Review the changes and merge when ready.
Changed files
.github/workflows/ci.ymlwith remotesync/.github/workflows/ci.ymlThis PR was created automatically by the repo-file-sync-action workflow run #22211856352