Skip to content

🔄 synced file(s) with OrrisTech/.github #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamzifei merged 1 commit into from
Feb 20, 2026
Merged

🔄 synced file(s) with OrrisTech/.github #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ concurrency:
jobs:
lint-typecheck:
name: Lint & Type Check
# Advisory only — does not block build or other jobs.
# Remove continue-on-error once repo lint errors are resolved.
continue-on-error: true
uses: OrrisTech/.github/.github/workflows/ci-lint-typecheck.yml@main
secrets: inherit

Expand All @@ -33,12 +36,13 @@ jobs:

build:
name: Build
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the needs: [lint-typecheck] dependency means the build job will now run in parallel with lint-typecheck instead of waiting for it to complete. Since lint-typecheck now has continue-on-error: true, this change makes sense to avoid blocking the build. However, this means builds could proceed even if lint checks are still running or have failed.

Consider whether this is the intended behavior for your CI pipeline. If you want to ensure builds only happen after linting completes (even if it fails), you should keep the needs dependency but rely on continue-on-error: true to prevent blocking.

Suggested change
name: Build
name: Build
needs: [lint-typecheck]

Copilot uses AI. Check for mistakes.
needs: [lint-typecheck]
uses: OrrisTech/.github/.github/workflows/ci-build.yml@main
secrets: inherit

security:
name: Security Audit
# Advisory only — does not block other jobs.
continue-on-error: true
uses: OrrisTech/.github/.github/workflows/ci-security.yml@main
secrets: inherit

Expand Down