IEBH-462: Fix issue with missing multipart upload parts#20
Merged
vmoshynskyi merged 2 commits intomainfrom Jan 6, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue with missing multipart upload parts by implementing error handling to skip uploads that no longer exist while logging a warning. The main change adds a try-catch block to handle NoSuchUpload errors gracefully instead of failing the entire operation.
Key Changes:
- Added error handling in
get_chunks_infoto catch and skip missing S3 multipart uploads with a warning message - Introduced Faker library for test data generation and created a custom Faker fixture with domain-specific methods
- Added a new test case to verify that missing uploads are properly skipped
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
app/routers/v1/api_resumable_upload/utils.py |
Added try-except block to handle NoSuchUpload errors and log warnings when multipart uploads don't exist |
tests/routers/v1/api_resumable_upload/test_resumable.py |
Added new test case for skipping missing chunks; removed unused pytest imports |
tests/fixtures/fake.py |
Created custom Faker fixture with helper methods for generating container, project, and dataset codes |
tests/fixtures/__init__.py |
Added license header to initialize fixtures module |
tests/conftest.py |
Registered the new fake fixture as a pytest plugin |
pyproject.toml |
Added Faker 40.1.0 as a dev dependency |
poetry.lock |
Updated lock file with Faker and tzdata package entries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip missing parts issuing a warning so that it is possible to continue without them.