Skip to content

IEBH-462: Fix issue with missing multipart upload parts#20

Merged
vmoshynskyi merged 2 commits intomainfrom
IEBH-462
Jan 6, 2026
Merged

IEBH-462: Fix issue with missing multipart upload parts#20
vmoshynskyi merged 2 commits intomainfrom
IEBH-462

Conversation

@vmoshynskyi
Copy link
Member

Skip missing parts issuing a warning so that it is possible to continue without them.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an issue with missing multipart upload parts by implementing error handling to skip uploads that no longer exist while logging a warning. The main change adds a try-catch block to handle NoSuchUpload errors gracefully instead of failing the entire operation.

Key Changes:

  • Added error handling in get_chunks_info to catch and skip missing S3 multipart uploads with a warning message
  • Introduced Faker library for test data generation and created a custom Faker fixture with domain-specific methods
  • Added a new test case to verify that missing uploads are properly skipped

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
app/routers/v1/api_resumable_upload/utils.py Added try-except block to handle NoSuchUpload errors and log warnings when multipart uploads don't exist
tests/routers/v1/api_resumable_upload/test_resumable.py Added new test case for skipping missing chunks; removed unused pytest imports
tests/fixtures/fake.py Created custom Faker fixture with helper methods for generating container, project, and dataset codes
tests/fixtures/__init__.py Added license header to initialize fixtures module
tests/conftest.py Registered the new fake fixture as a pytest plugin
pyproject.toml Added Faker 40.1.0 as a dev dependency
poetry.lock Updated lock file with Faker and tzdata package entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
__main__.py050%7, 9, 11–13
api_registry.py00100% 
config.py00100% 
logger.py00100% 
main.py0783%80–81, 83–85, 87, 91
commons
   __init__.py00100% 
   kafka_producer.py02744%32–39, 41, 48–50, 62–66, 82–84, 86, 88, 108, 110, 126–127, 129
commons/data_providers
   __init__.py00100% 
   redis.py01660%28–29, 37, 40, 43, 46, 49–51, 54, 57, 60–64
   redis_project_session_job.py02470%66, 71, 73, 75, 88, 91–96, 203–204, 210–215, 217–220, 222
components
   __init__.py00100% 
components/request
   __init__.py00100% 
   network.py00100% 
models
   __init__.py00100% 
   base_models.py00100% 
   folder.py0890%101, 117, 126–131
   models_item.py0185%23
   models_resumable_upload.py00100% 
   models_upload.py00100% 
resources
   __init__.py00100% 
   archive_file_type_mapping.py00100% 
   decorator.py00100% 
   error_handler.py01669%34–40, 50–57, 82
   health_check.py02921%25–29, 31–35, 49–50, 52–54, 56–58, 60–63, 65, 78–81, 83–84
   helpers.py01887%26, 31, 36, 138–140, 148–150, 158–160, 168–170, 197–199
   lock.py0250%7, 9, 12–13, 16–22, 24, 27–28, 31–32, 35–36, 38–43, 45
routers
   __init__.py00100% 
   api_root.py0673%40–41, 43, 52–54
   exceptions.py0983%24, 31, 38, 54, 58, 62, 92, 96, 100
routers/v1
   __init__.py00100% 
   api_data_upload.py07376%120–122, 261–262, 267–268, 325–327, 329, 335–336, 338–339, 362, 364–365, 367–373, 375, 521–523, 604, 662–666, 668–669, 675–678, 698, 700–702, 711–714, 716–717, 719, 737–740, 750–753, 755–756, 764, 769–778
   exceptions.py00100% 
routers/v1/api_resumable_upload
   __init__.py00100% 
   api_resumable_upload.py0392%50–52
   utils.py0193%25
TOTAL119526877% 

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vmoshynskyi vmoshynskyi merged commit 325de23 into main Jan 6, 2026
12 checks passed
@vmoshynskyi vmoshynskyi deleted the IEBH-462 branch January 6, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant