State V2 and actually use GLRenderer #594
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for GradleBuild :: build
|
Deftu
approved these changes
Dec 1, 2025
There was a problem hiding this comment.
Pull request overview
This PR upgrades the PolyUI library from version 1.15.2 to 2.0.4 and refactors the codebase to use the new State V2 API. Additionally, it switches from NVGRendererImpl to GLRendererImpl for rendering and includes several bug fixes.
Key changes:
- Migration to State V2 API with bidirectional state binding between UI components and properties
- Switch from framebuffer-based rendering to direct viewport-based rendering using GLRenderer
- Fixed error message in EventManager to correctly display handler class name
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/ui/src/main/kotlin/org/polyfrost/oneconfig/api/ui/v1/internal/GLRendererImpl.kt | Added null-safety checks for glyph operations and range validation for character codes |
| modules/internal/src/main/kotlin/org/polyfrost/oneconfig/internal/ui/OneConfigUI.kt | Refactored search functionality to use State V2 with listener pattern instead of onChange callbacks |
| modules/hud/src/main/kotlin/org/polyfrost/oneconfig/api/hud/v1/internal/hudpages.kt | Migrated HUD settings to State V2 API, replacing manual onChange handlers with state binding |
| modules/events/src/main/java/org/polyfrost/oneconfig/api/event/v1/EventManager.java | Fixed error message to show correct handler class name instead of event class name |
| modules/config/src/main/java/org/polyfrost/oneconfig/api/config/v1/Property.java | Changed set/setReferential methods to return boolean, added removeCallback functionality |
| modules/config-impl/src/main/kotlin/org/polyfrost/oneconfig/api/config/v1/internal/ConfigVisualizer.kt | Updated accordion state handling to use State objects instead of primitives |
| modules/config-impl/src/main/kotlin/org/polyfrost/oneconfig/api/config/v1/Visualizer.kt | Added toState() and toEnumState() methods for Property-to-State conversion with weak references |
| minecraft/src/main/java/org/polyfrost/oneconfig/api/ui/v1/internal/wrappers/PolyUIScreen.java | Removed framebuffer rendering, switched to direct viewport manipulation for GLRenderer compatibility |
| minecraft/src/main/java/org/polyfrost/oneconfig/api/ui/v1/internal/UIManagerImpl.java | Switched from NVGRendererImpl to GLRendererImpl |
| gradle/libs.versions.toml | Upgraded PolyUI dependency from 1.15.2 to 2.0.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
modules/internal/src/main/kotlin/org/polyfrost/oneconfig/internal/ui/OneConfigUI.kt
Show resolved
Hide resolved
modules/ui/src/main/kotlin/org/polyfrost/oneconfig/api/ui/v1/internal/GLRendererImpl.kt
Outdated
Show resolved
Hide resolved
modules/hud/src/main/kotlin/org/polyfrost/oneconfig/api/hud/v1/internal/hudpages.kt
Show resolved
Hide resolved
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
…, remove old code from LegacyHud
…er' into state-v2-and-actually-use-glrenderer
Job Summary for GradleBuild :: build
|
Wyvest
requested changes
Dec 10, 2025
| renderer.accept(event.ctx); | ||
| }); | ||
| // todo temporary reversion: on RenderEvent it just renders nothing (see #592, #579) | ||
| EventManager.register(HudRenderEvent.class, event -> renderer.accept(event.ctx)); |
Member
There was a problem hiding this comment.
is this something we should put on our issues board
Job Summary for GradleBuild :: build
|
…er' into state-v2-and-actually-use-glrenderer
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Job Summary for GradleBuild :: build
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist