[WIP] UserChallengeStatus 오류 수정 #265
Open
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daclouds
reviewed
Dec 19, 2025
| available_ids = members.copy() | ||
| random.shuffle(available_ids) | ||
|
|
||
| members = list(set(members)) |
Collaborator
There was a problem hiding this comment.
중복이 있는 상태에서 set 에 넣어 중복을 제거하는 것 보단 중복을 만들지 않는 게 어떨까요? 😉 #267
hu6r1s
reviewed
Dec 20, 2025
Comment on lines
40
to
48
| for user_id in members: | ||
| possible_ids = [uid for uid in available_ids if uid != user_id] | ||
| if not possible_ids: | ||
| raise ValueError(f"{user_id}에게 할당할 문제 부족") | ||
|
|
||
| assigned_user_id = random.choice(possible_ids) | ||
| assigned_question = random.choice([q for q in team_questions if q.user_id == assigned_user_id]) | ||
|
|
||
| available_ids.remove(assigned_user_id) |
Collaborator
There was a problem hiding this comment.
이거 에러날 수도 있겠는데요?
members = [2, 3, 4, 5]
available_ids = [3, 2, 5, 4]
user_id = 2
possible_ids = [3, 5, 4]
assigned_user_id = 3
available_ids = [2, 5, 4]
user_id = 3
possible_ids = [2, 5, 4]
assigned_user_id = 4
available_ids = [2, 5]
user_id = 4
possible_ids = [2, 5]
assigned_user_id = 2
available_ids = [5]
user_id = 5
possible_ids = []
이렇게 되면 ValueError(f"{user_id}에게 할당할 문제 부족")가 나올 것 같아요
Collaborator
There was a problem hiding this comment.
유저는 중복 허용하고 문제만 중복되지 않게 하는 건 어떨까요? 👀
category 가 3개라면 len(mebmers) * category 가 되어서 문제는 충분 할 것 같거든요.
2번 유저의 문제를 푸는 사람이 4, 5 일 수 있게?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 PR 타입
📜 설명
엮인 이슈
🔨 작업 내용
백엔드 로그:
getcloser-backend-1 | assigned_user_id: 1
getcloser-backend-1 | assigned_question: <models.challenge_question.ChallengeQuestion object at 0xffffa36d20b0>
getcloser-backend-1 | assigned_list: [AssignedChallenge(user_id=1, assigned_challenge_id=4, from_user_id=2, category='1', answer='AI Agent'), AssignedChallenge(user_id=2, assigned_challenge_id=2, from_user_id=1, category='2', answer='등산')]
📸 스크린샷
🧑💻 테스트 결과
📅 체크리스트