-
Notifications
You must be signed in to change notification settings - Fork 3
[WIP] UserChallengeStatus 오류 수정 #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,16 +36,34 @@ def assign_challenges_logic(my_id: str, members: list, db: Session) -> list: | |
| available_ids = members.copy() | ||
| random.shuffle(available_ids) | ||
|
|
||
| members = list(set(members)) | ||
| for user_id in members: | ||
| possible_ids = [uid for uid in available_ids if uid != user_id] | ||
| if not possible_ids: | ||
| raise ValueError(f"{user_id}에게 할당할 문제 부족") | ||
|
|
||
| assigned_user_id = random.choice(possible_ids) | ||
| assigned_question = random.choice([q for q in team_questions if q.user_id == assigned_user_id]) | ||
|
|
||
| available_ids.remove(assigned_user_id) | ||
|
Comment on lines
40
to
48
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이거 에러날 수도 있겠는데요? user_id = 2 user_id = 3 user_id = 4 user_id = 5 이렇게 되면 ValueError(f"{user_id}에게 할당할 문제 부족")가 나올 것 같아요
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 유저는 중복 허용하고 문제만 중복되지 않게 하는 건 어떨까요? 👀 2번 유저의 문제를 푸는 사람이 4, 5 일 수 있게?! |
||
|
|
||
| # ✅ UserChallengeStatus 업데이트 | ||
| user_status = ( | ||
| db.query(UserChallengeStatus) | ||
| .filter(UserChallengeStatus.user_id == user_id) | ||
| .first() | ||
| ) | ||
|
|
||
| if not user_status: | ||
| raise HTTPException(status_code=404, detail="UserChallengeStatus 없음") | ||
|
|
||
| user_status.challenge_id = assigned_question.id | ||
| user_status.submitted_at = None | ||
| user_status.is_correct = False | ||
| user_status.is_redeemed = False | ||
|
|
||
| db.add(user_status) | ||
|
|
||
| assigned_list.append(AssignedChallenge( | ||
| user_id=user_id, | ||
| assigned_challenge_id=assigned_question.id, | ||
|
|
@@ -54,6 +72,8 @@ def assign_challenges_logic(my_id: str, members: list, db: Session) -> list: | |
| answer=assigned_question.answer | ||
| )) | ||
|
|
||
| db.commit() | ||
|
|
||
| return assigned_list[0] | ||
|
|
||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
중복이 있는 상태에서 set 에 넣어 중복을 제거하는 것 보단 중복을 만들지 않는 게 어떨까요? 😉 #267