unified docker.sh script for improved docker management#1342
Merged
Conversation
- Replaced docker-dev.sh with a unified docker.sh script for improved Docker management. - Removed docker-quickstart.sh and validate-docker.sh as they are no longer needed. - Introduced agent-setup.sh and agent-teardown.sh for hands-off Docker environment setup for agent worktrees. - Updated package.json to reflect new script paths and commands. - Added session injection endpoint in auth.ts for testing purposes, allowing agents to authenticate without OAuth. - Enhanced logging and error handling across scripts for better debugging and user feedback.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the repository’s Docker developer workflow by consolidating scripts into a single docker.sh, adding agent/worktree setup scripts, and introducing a development-only session injection endpoint to support agent/e2e authentication without OAuth.
Changes:
- Replaced multiple Docker helper scripts with a unified
scripts/docker.shand updated npm scripts/docs accordingly. - Added
scripts/agent-setup.sh/scripts/agent-teardown.shto create isolated Docker environments per worktree (unique ports + project name). - Added a session injection route under
/auth/inject-session, gated by environment flags, to support agent/e2e testing.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| server/utils/environment.ts | Adds env keys for session injection feature flags. |
| server/routes/auth.ts | Adds session injection route gated by env vars. |
| scripts/docker.sh | New unified Docker management script (start/stop/logs/etc.). |
| scripts/agent-setup.sh | New agent/worktree Docker bootstrap with deterministic port selection. |
| scripts/agent-teardown.sh | New agent/worktree teardown + optional worktree removal. |
| package.json | Updates npm scripts to point to scripts/docker.sh and adds db/redis/status helpers. |
| DOCKER.md | Updates Docker workflow docs; adds agent/worktree and session injection sections. |
| AGENTS.md | Updates agent guidance to new Docker commands and agent scripts. |
| .gitignore | Ignores .agent-env generated by agent scripts. |
| .github/agents/did-code-assistant.agent.md | Updates internal agent instructions for the new Docker workflow. |
| scripts/docker-dev.sh | Removed legacy Docker dev script. |
| scripts/docker-quickstart.sh | Removed legacy quickstart script. |
| scripts/validate-docker.sh | Removed legacy Docker validation script. |
Member
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
7 tasks
Contributor
…n injection (#1345) * Initial plan * fix: apply security and robustness improvements from code review Co-authored-by: damsleth <7300548+damsleth@users.noreply.github.com> * fix: add timing-safe comparison and handle edge cases Co-authored-by: damsleth <7300548+damsleth@users.noreply.github.com> * fix: add buffer length check and improve .env parsing robustness Co-authored-by: damsleth <7300548+damsleth@users.noreply.github.com> * refactor: use case-insensitive header lookup and DRY principle Co-authored-by: damsleth <7300548+damsleth@users.noreply.github.com> * fix: correct quote stripping pattern and use consistent session indexing Co-authored-by: damsleth <7300548+damsleth@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: damsleth <7300548+damsleth@users.noreply.github.com>
Member
Author
|
@copilot fix this build error: |
7 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Docker scripts and enhance session management