Security hardening and robustness fixes for Docker scripts and session injection #1345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
npm run watchReview checklist
Review theme song
🎵 Tool - Forty Six & 2 🎵
Description
Addresses security vulnerabilities and robustness issues in the session injection endpoint and Docker environment scripts.
Session Injection Endpoint Security
SESSION_INJECTION_SECRETwithcrypto.timingSafeEqual()for timing-attack resistanceNODE_ENV=developmentguardObject.assignDocker Script Robustness
COMPOSE_PROJECT_NAMEfor Docker Compose compatibility (lowercase, alphanumeric+hyphens).envfile sourcing (code execution risk) with safe key-value parsing=characters correctly#or=docker compose versionvalidation checkDocumentation
9142with dynamic${APP_URL}referencesX-Injection-SecretheaderBefore:
After:
How to test
gh pr checkout 1342./scripts/agent-setup.shin a worktree with special characters (e.g.,Test.Branch-123)TEST_SESSION_COOKIEandSESSION_INJECTION_SECRETenvironment variablesRelated PRs
Addresses all review comments from PR #1342
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.