feat: Refactor Remittance Split Error Handling#113
Open
mansory-01 wants to merge 1 commit intoRemitwise-Org:mainfrom
Open
feat: Refactor Remittance Split Error Handling#113mansory-01 wants to merge 1 commit intoRemitwise-Org:mainfrom
mansory-01 wants to merge 1 commit intoRemitwise-Org:mainfrom
Conversation
Contributor
|
@mansory-01 please fix the pipeline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
remittance_splitcontract to improve error consistency and safety. It introduces a customRemittanceSplitErrorenum and updates all public methods to returnResultinstead of panicking, aligning the contract with thebill_paymentspattern.Changes
Custom Error Enum
RemittanceSplitErrorenum with descriptive variants includingPercentagesDoNotSumTo100,InvalidAmount, andUnauthorized.Result-Based Refactoring
initialize_split,update_split, andcalculate_splitto returnResultinstead of panicking.create,modify,cancel) to returnResultfor consistent error propagation.Contract Fixes & Cleanup
lib.rs.calculate_splitto remove redundancy.gas_bench.rs.Test Suite Updates
RemittanceSplitErrorenum.Checklist
RemittanceSplitErrorenum introduced with descriptive variantsinitialize_split,update_split, andcalculate_splitrefactored to returnResultcreate,modify,cancel) refactored to returnResultlib.rsfixedcalculate_splitconsolidatedgas_bench.rsresolvedcargo test -p remittance_splitcloses #71