Skip to content

feat: Refactor Remittance Split Error Handling #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mansory-01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Refactor Remittance Split Error Handling #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
206 changes: 40 additions & 166 deletions remittance_split/src/lib.rs
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions remittance_split/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ fn test_initialize_split_invalid_sum() {
&50, &50, &10, // Sums to 110
&0,
);
assert_eq!(result, Err(Ok(RemittanceSplitError::InvalidPercentages)));
assert_eq!(result, Err(Ok(RemittanceSplitError::PercentagesDoNotSumTo100)));
}

#[test]
Expand Down Expand Up @@ -310,7 +310,7 @@ fn test_remittance_schedule_validation() {
client.initialize_split(&owner, &0, &50, &30, &15, &5);

let result = client.try_create_remittance_schedule(&owner, &10000, &3000, &86400);
assert!(result.is_err());
assert_eq!(result, Err(Ok(RemittanceSplitError::InvalidDueDate)));
}

#[test]
Expand All @@ -326,5 +326,5 @@ fn test_remittance_schedule_zero_amount() {
client.initialize_split(&owner, &0, &50, &30, &15, &5);

let result = client.try_create_remittance_schedule(&owner, &0, &3000, &86400);
assert!(result.is_err());
assert_eq!(result, Err(Ok(RemittanceSplitError::InvalidAmount)));
}
168 changes: 168 additions & 0 deletions remittance_split/test_snapshots/test/test_calculate_complex_rounding.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,90 @@
},
"failed_call": false
},
{
"event": {
"ext": "v0",
"contract_id": "0000000000000000000000000000000000000000000000000000000000000001",
"type_": "contract",
"body": {
"v0": {
"topics": [
{
"symbol": "calc"
}
],
"data": {
"map": [
{
"key": {
"symbol": "bills_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 230
}
}
},
{
"key": {
"symbol": "insurance_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 410
}
}
},
{
"key": {
"symbol": "savings_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 190
}
}
},
{
"key": {
"symbol": "spending_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 170
}
}
},
{
"key": {
"symbol": "timestamp"
},
"val": {
"u64": 0
}
},
{
"key": {
"symbol": "total_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 1000
}
}
}
]
}
}
}
},
"failed_call": false
},
{
"event": {
"ext": "v0",
Expand Down Expand Up @@ -512,6 +596,90 @@
},
"failed_call": false
},
{
"event": {
"ext": "v0",
"contract_id": "0000000000000000000000000000000000000000000000000000000000000001",
"type_": "contract",
"body": {
"v0": {
"topics": [
{
"symbol": "calc"
}
],
"data": {
"map": [
{
"key": {
"symbol": "bills_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 0
}
}
},
{
"key": {
"symbol": "insurance_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 3
}
}
},
{
"key": {
"symbol": "savings_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 0
}
}
},
{
"key": {
"symbol": "spending_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 0
}
}
},
{
"key": {
"symbol": "timestamp"
},
"val": {
"u64": 0
}
},
{
"key": {
"symbol": "total_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 3
}
}
}
]
}
}
}
},
"failed_call": false
},
{
"event": {
"ext": "v0",
Expand Down
84 changes: 84 additions & 0 deletions remittance_split/test_snapshots/test/test_calculate_split.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,90 @@
},
"failed_call": false
},
{
"event": {
"ext": "v0",
"contract_id": "0000000000000000000000000000000000000000000000000000000000000001",
"type_": "contract",
"body": {
"v0": {
"topics": [
{
"symbol": "calc"
}
],
"data": {
"map": [
{
"key": {
"symbol": "bills_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 150
}
}
},
{
"key": {
"symbol": "insurance_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 50
}
}
},
{
"key": {
"symbol": "savings_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 300
}
}
},
{
"key": {
"symbol": "spending_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 500
}
}
},
{
"key": {
"symbol": "timestamp"
},
"val": {
"u64": 0
}
},
{
"key": {
"symbol": "total_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 1000
}
}
}
]
}
}
}
},
"failed_call": false
},
{
"event": {
"ext": "v0",
Expand Down
84 changes: 84 additions & 0 deletions remittance_split/test_snapshots/test/test_calculate_split_rounding.1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,90 @@
},
"failed_call": false
},
{
"event": {
"ext": "v0",
"contract_id": "0000000000000000000000000000000000000000000000000000000000000001",
"type_": "contract",
"body": {
"v0": {
"topics": [
{
"symbol": "calc"
}
],
"data": {
"map": [
{
"key": {
"symbol": "bills_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 33
}
}
},
{
"key": {
"symbol": "insurance_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 1
}
}
},
{
"key": {
"symbol": "savings_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 33
}
}
},
{
"key": {
"symbol": "spending_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 33
}
}
},
{
"key": {
"symbol": "timestamp"
},
"val": {
"u64": 0
}
},
{
"key": {
"symbol": "total_amount"
},
"val": {
"i128": {
"hi": 0,
"lo": 100
}
}
}
]
}
}
}
},
"failed_call": false
},
{
"event": {
"ext": "v0",
Expand Down
Loading
Loading