[Destinations] Improve Options Class #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
added
please merge
MatKuhr
commented
Oct 7, 2025
| */ | ||
| @Nonnull | ||
| String getSuffix() | ||
| public String getSuffix() |
Member
Author
There was a problem hiding this comment.
Since its not obvious from this diff: The enum is already @Beta
newtork
approved these changes
Oct 7, 2025
Member
There was a problem hiding this comment.
Should we also add an overloaded method which takes in destination / fragment name as a param?
Member
Author
There was a problem hiding this comment.
Hmm personally I feel the logic is simple enough to not add more public API, but no strong opinion
thisisjustinm
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Small improvement requested by a user.
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated