Skip to content

[Destinations] Improve Options Class #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatKuhr merged 1 commit into from
Oct 7, 2025
Merged

[Destinations] Improve Options Class #958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...java/com/sap/cloud/sdk/cloudplatform/connectivity/DestinationServiceOptionsAugmenter.java
View file
Open in desktop
Copy link
Member

@thisisjustinm thisisjustinm Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add an overloaded method which takes in destination / fragment name as a param?

Copy link
Member Author

@MatKuhr MatKuhr Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm personally I feel the logic is simple enough to not add more public API, but no strong opinion

Copy link
Member

@thisisjustinm thisisjustinm Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,13 @@ public enum CrossLevelScope

private final String identifier;

/**
* Return the suffix to be appended to e.g. a destination or fragment name.
*
* @return The suffix including the leading '@' character.
*/
@Nonnull
String getSuffix()
public String getSuffix()
Copy link
Member Author

@MatKuhr MatKuhr Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since its not obvious from this diff: The enum is already @Beta

{
return "@" + identifier;
}
Expand Down