Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Sep 30, 2025

Description

Folded into #1004

Implements the distinction between node output and taskOutput node types, and input and taskInput - as a subset of the respective task node.

To make this work the entire handleConnection utility was refactored. It should now be much more human-readable.

Related Issue and Pull requests

Progresses Shopify/oasis-frontend#261

Type of Change

  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Additional Comments

Copy link
Collaborator Author

camielvs commented Sep 30, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from ea1273a to f97f59a Compare October 1, 2025 23:16
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from 41380fe to 972ef4a Compare October 1, 2025 23:16
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from 972ef4a to d32734d Compare October 2, 2025 00:57
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from f97f59a to 36459f6 Compare October 2, 2025 00:57
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from d32734d to cc0477e Compare October 7, 2025 22:53
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 36459f6 to ac15e08 Compare October 7, 2025 22:53
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from cc0477e to 7a923f3 Compare October 7, 2025 23:23
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from ac15e08 to 281533c Compare October 7, 2025 23:23
This was referenced Oct 7, 2025
@camielvs camielvs changed the base branch from 09-29-add_debug_mode_for_viewing_reactflow_node_ids to graphite-base/1017 October 7, 2025 23:47
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from 7a923f3 to b33644c Compare October 8, 2025 00:38
@camielvs camielvs force-pushed the graphite-base/1017 branch from 281533c to 27ccde3 Compare October 8, 2025 00:38
@camielvs camielvs changed the base branch from graphite-base/1017 to 09-29-add_debug_mode_for_viewing_reactflow_node_ids October 8, 2025 00:38
@camielvs camielvs changed the base branch from 09-29-add_debug_mode_for_viewing_reactflow_node_ids to graphite-base/1017 October 8, 2025 00:55
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from b33644c to a0239ca Compare October 8, 2025 00:55
@camielvs camielvs force-pushed the graphite-base/1017 branch from 27ccde3 to 8396c6f Compare October 8, 2025 00:55
@camielvs camielvs changed the base branch from graphite-base/1017 to 09-29-implement_node_manager October 8, 2025 00:56
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from a0239ca to 9c8c8f8 Compare October 8, 2025 01:06
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 8396c6f to 83ecf4a Compare October 8, 2025 01:06
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch 2 times, most recently from 3076c14 to d6ce75d Compare October 8, 2025 16:16
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch 2 times, most recently from 48b8ebd to aa7be5c Compare October 8, 2025 16:31
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from d6ce75d to c05da47 Compare October 8, 2025 16:31
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from aa7be5c to f779e3b Compare October 8, 2025 16:52
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch 3 times, most recently from 7f1c898 to b6be3d3 Compare October 8, 2025 17:58
@camielvs camielvs force-pushed the 09-29-implement_node_manager branch from 3bdf6ed to 240932c Compare October 8, 2025 17:58
@camielvs camielvs force-pushed the 09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids branch from b6be3d3 to 81c1c02 Compare October 8, 2025 20:02
@camielvs camielvs changed the base branch from 09-29-implement_node_manager to graphite-base/1017 October 8, 2025 20:08
@camielvs camielvs closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants