forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 5
Split TaskInput and TaskOutput Node Ids from Input and Output Node Ids #1017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
camielvs
wants to merge
3
commits into
graphite-base/1017
from
09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids
Closed
Split TaskInput and TaskOutput Node Ids from Input and Output Node Ids #1017
camielvs
wants to merge
3
commits into
graphite-base/1017
from
09-29-split_taskinput_and_taskoutput_node_ids_from_input_and_output_node_ids
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2025
Draft
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ea1273a to
f97f59a
Compare
41380fe to
972ef4a
Compare
This was referenced Oct 2, 2025
972ef4a to
d32734d
Compare
f97f59a to
36459f6
Compare
d32734d to
cc0477e
Compare
36459f6 to
ac15e08
Compare
cc0477e to
7a923f3
Compare
ac15e08 to
281533c
Compare
7a923f3 to
b33644c
Compare
281533c to
27ccde3
Compare
b33644c to
a0239ca
Compare
27ccde3 to
8396c6f
Compare
a0239ca to
9c8c8f8
Compare
8396c6f to
83ecf4a
Compare
3076c14 to
d6ce75d
Compare
48b8ebd to
aa7be5c
Compare
d6ce75d to
c05da47
Compare
aa7be5c to
f779e3b
Compare
7f1c898 to
b6be3d3
Compare
3bdf6ed to
240932c
Compare
3 tasks
b6be3d3 to
81c1c02
Compare
This was referenced Oct 9, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Folded into #1004
Implements the distinction between node
outputandtaskOutputnode types, andinputandtaskInput- as a subset of the respective task node.To make this work the entire
handleConnectionutility was refactored. It should now be much more human-readable.Related Issue and Pull requests
Progresses Shopify/oasis-frontend#261
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments