Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Sep 20, 2025

Description

Adds a new top-level class NodeManager to handle conversion between static ReactFlow node ids and potentially non-static task ids.

Node ids are a randomly generated unique id internal to the app and specifically used to maintain ReactFlow state. The Node Manager creates, stores and, when necessary, removes these ids and maps them 1:1 with the relevant refId, where refId is any key (though typically a taskId, inputName or outputName.

ReactFlow Node ids will now be related to tasks as follows:

  • node id <--Node Manager--> task id
  • node id <--Node Manager--> input name
  • node id <--Node Manager--> output name

Task inputs & task outputs are are mapped via their Handle relative to the task/object they are on.

No change to app functionality. Implementation of the node manager will come in upstack PRs.

Related Issue and Pull requests

Progresses https://github.com/Shopify/oasis-frontend/issues/261

Type of Change

  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

This PR adds a bunch of code without tying it into the existing app so it cannot be test through UI.

Review the test file to see if the core functionality works as expected.

Additional Comments

Copy link
Collaborator Author

camielvs commented Sep 20, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs mentioned this pull request Sep 20, 2025
3 tasks
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from 1166ce3 to d738a0a Compare September 20, 2025 00:31
@camielvs camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 34238bb to 11d5dce Compare September 20, 2025 00:31
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from d738a0a to 8bba722 Compare September 29, 2025 19:44
@camielvs camielvs force-pushed the 09-19-stricter_typing_on_nodes branch 2 times, most recently from 7dcc9ba to eae31b0 Compare September 29, 2025 20:08
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from 8bba722 to 4eed892 Compare September 29, 2025 20:08
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from 4eed892 to e65db05 Compare October 1, 2025 23:16
@camielvs camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from eae31b0 to 9511aeb Compare October 1, 2025 23:16
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from e65db05 to d13ac40 Compare October 7, 2025 22:53
@camielvs camielvs force-pushed the 09-19-stricter_typing_on_nodes branch from 9511aeb to a6337e1 Compare October 7, 2025 22:53
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from d13ac40 to 43a282b Compare October 7, 2025 23:23
This was referenced Oct 7, 2025
@camielvs camielvs changed the base branch from 09-19-stricter_typing_on_nodes to graphite-base/929 October 8, 2025 16:52
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from 43a282b to 3e1ef82 Compare October 8, 2025 16:52
@camielvs camielvs changed the base branch from graphite-base/929 to 09-29-add_debug_mode_for_viewing_reactflow_node_ids October 8, 2025 16:52
@camielvs camielvs force-pushed the 09-19-add_node_manager branch 2 times, most recently from 47571c0 to bf97171 Compare October 8, 2025 17:58
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from bf97171 to a82859b Compare October 8, 2025 20:02
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from e64dccf to 8622de6 Compare October 17, 2025 18:47
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from c754609 to 45adef9 Compare October 17, 2025 21:41
@camielvs camielvs force-pushed the 09-19-add_node_manager branch 2 times, most recently from 0e9a8ad to 13d6255 Compare October 17, 2025 21:42
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 45adef9 to c099a92 Compare October 17, 2025 21:42
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from 13d6255 to e98225e Compare October 22, 2025 20:18
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch 2 times, most recently from 8a10101 to 8be46ba Compare October 22, 2025 22:19
@camielvs camielvs force-pushed the 09-19-add_node_manager branch 2 times, most recently from 7ab0232 to 68217dd Compare October 23, 2025 16:35
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 8be46ba to 609e209 Compare October 23, 2025 16:35
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from 68217dd to f148c44 Compare October 23, 2025 19:34
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from 609e209 to a8907f7 Compare October 23, 2025 19:34
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from f148c44 to e3374bf Compare October 23, 2025 20:11
@camielvs camielvs force-pushed the 09-29-add_debug_mode_for_viewing_reactflow_node_ids branch from a8907f7 to 9b83881 Compare October 23, 2025 23:23
@camielvs camielvs force-pushed the 09-19-add_node_manager branch 2 times, most recently from 36ea9e6 to a3b0e3f Compare October 24, 2025 00:15
@camielvs camielvs changed the base branch from 09-29-add_debug_mode_for_viewing_reactflow_node_ids to graphite-base/929 October 28, 2025 21:04
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from a3b0e3f to 8114ef9 Compare October 28, 2025 21:04
@camielvs camielvs changed the base branch from graphite-base/929 to 10-08-add_input_id_and_output_id_conversions October 28, 2025 21:04
@maxy-shpfy maxy-shpfy marked this pull request as draft October 30, 2025 16:55
@camielvs camielvs force-pushed the 10-08-add_input_id_and_output_id_conversions branch from f745e06 to b7a76f2 Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from 8114ef9 to 5472e7b Compare October 30, 2025 19:10
@camielvs camielvs force-pushed the 10-08-add_input_id_and_output_id_conversions branch from b7a76f2 to ad7c169 Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from 5472e7b to ad2e6c4 Compare October 30, 2025 19:44
@camielvs camielvs force-pushed the 10-08-add_input_id_and_output_id_conversions branch from ad7c169 to 5d57dc5 Compare October 31, 2025 00:23
@camielvs camielvs force-pushed the 09-19-add_node_manager branch from ad2e6c4 to 0fa81ee Compare October 31, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants