Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Dec 4, 2025

Description

Move PipelineDetails onto UI Primitives and ContextPanel Blocks for closer visual consistency with TaskDetails.

As part of this, files were moved to a new Context folder.

Additionally, a new PipelineIO component was added, which is very similar to the existing ArtifactsList but slightly different in how it handles data (and uses new Block components). As such, for this PR only the ArtifactsList and PipelineIO components live side-by-side in the directory. One is consumed by PipelineDetails, the other by RunDetails. ArtifactsList is then removed completely when RunDetails is migrated and cleaned up in the next PR. Most of the visual aspects of ArtifactsList are included in PipelineIO.

A note on Duplicate Efforts:
There was no intent to create a duplicate artifact/IO list. PipelineIO was created before ArtifactsList came into being and when I compared the two to see the similarities I decided to adopt the UI of ArtifactsList into the functionality/structure of PipelineIO.

This PR also fixes some text overflow bugs in the artifact list.

Related Issue and Pull requests

https://github.com/Shopify/oasis-frontend/issues/401

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Before After
image.png image.png

Test Instructions

No change to app functionality. UI update only. Confirm that the interface works and shows info as expected.

Additional Comments

@camielvs camielvs mentioned this pull request Dec 4, 2025
3 tasks
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from ceb7ba3 to 53746fd Compare December 4, 2025 21:26
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from f1fefa5 to 17c6996 Compare December 4, 2025 21:26
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from 53746fd to f97eef2 Compare December 4, 2025 21:52
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from 17c6996 to 748d25b Compare December 4, 2025 21:52
@camielvs camielvs mentioned this pull request Dec 4, 2025
4 tasks
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from f97eef2 to 484ef28 Compare December 4, 2025 21:59
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from 748d25b to 4f787bc Compare December 4, 2025 21:59
@camielvs camielvs mentioned this pull request Dec 4, 2025
3 tasks
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from 4f787bc to ef11837 Compare December 4, 2025 22:29
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch 2 times, most recently from 7fdce0e to 07681e8 Compare December 4, 2025 22:44
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from ef11837 to 04c9d4b Compare December 4, 2025 22:44
@camielvs camielvs mentioned this pull request Dec 4, 2025
3 tasks
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from 07681e8 to f00aef0 Compare December 4, 2025 22:47
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from 04c9d4b to ce43d7d Compare December 4, 2025 22:47
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from f00aef0 to 4d24ab8 Compare December 4, 2025 22:49
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch 2 times, most recently from 9aa4c6d to cfd1925 Compare December 5, 2025 01:53
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from 4d24ab8 to 0c4463a Compare December 5, 2025 01:53
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from 0c4463a to 9bbe550 Compare December 8, 2025 23:41
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch 2 times, most recently from 98efbba to b61217a Compare December 9, 2025 01:48
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch 3 times, most recently from 8d60661 to f368fb8 Compare December 9, 2025 02:07
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch 2 times, most recently from 4926ca2 to d8a9ef8 Compare December 17, 2025 20:32
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from 8d6e5bd to 9f12c4f Compare December 17, 2025 20:32
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from d8a9ef8 to c70298d Compare December 17, 2025 20:34
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from 9f12c4f to 5257308 Compare December 17, 2025 20:34
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from c70298d to 6a78b72 Compare December 17, 2025 20:56
@camielvs camielvs requested a review from morgan-wowk December 17, 2025 20:57
Copy link

@morgan-wowk morgan-wowk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from 6a78b72 to fadfee9 Compare December 18, 2025 16:03
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from 5257308 to 5231971 Compare December 18, 2025 16:03
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from fadfee9 to ac114e5 Compare December 18, 2025 16:10
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch 2 times, most recently from 2a594fc to 8633795 Compare December 18, 2025 19:28
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from ac114e5 to ee9d94e Compare December 18, 2025 19:28
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from 8633795 to a14d94e Compare December 18, 2025 19:34
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from ee9d94e to ff73971 Compare December 18, 2025 19:34
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch from a14d94e to 1bdd5d3 Compare December 18, 2025 20:35
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from ff73971 to e5c8c47 Compare December 18, 2025 20:35
@camielvs camielvs force-pushed the 12-02-cleanup_taskdetails branch 2 times, most recently from 540b3d3 to 2d25276 Compare December 18, 2025 20:43
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from e5c8c47 to 78723bb Compare December 18, 2025 20:43
@camielvs camielvs changed the base branch from 12-02-cleanup_taskdetails to graphite-base/1468 December 18, 2025 20:48
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from 78723bb to 31883ac Compare December 18, 2025 20:49
@graphite-app graphite-app bot changed the base branch from graphite-base/1468 to master December 18, 2025 20:49
@camielvs camielvs force-pushed the 12-03-cleanup_pipelinedetails branch from 31883ac to 316385c Compare December 18, 2025 20:50
Copy link
Collaborator Author

camielvs commented Dec 18, 2025

Merge activity

  • Dec 18, 8:54 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 18, 8:54 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs merged commit 05f8f61 into master Dec 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants