Skip to content

Cleanup ExecutionDetails #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
camielvs merged 1 commit into from
Dec 18, 2025
Merged

Cleanup ExecutionDetails #1471

camielvs merged 1 commit into from
Dec 18, 2025

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Dec 4, 2025 •
edited
Loading

Description

Moves ExecutionDetails onto UI Primitives and the new Context Panel Blocks.

Also colocates the file with TaskDetails, since the component is not being consumed anywhere else.

Related Issue and Pull requests

https://github.com/Shopify/oasis-frontend/issues/401

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Before:

image.png

After:

image.png

Test Instructions

No change to app functionality. UI update only. Confirm that the interface works and shows info as expected.

Additional Comments

This was referenced Dec 4, 2025
Merged
Merged
@camielvs Graphite App
Copy link
Collaborator Author

camielvs commented Dec 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camielvs camielvs mentioned this pull request Dec 4, 2025
Merged
4 tasks
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from 54e3528 to e6ea5d1 Compare December 4, 2025 22:44
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from 49d4edd to 533c465 Compare December 4, 2025 22:44
@camielvs camielvs mentioned this pull request Dec 4, 2025
Merged
3 tasks
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from e6ea5d1 to 87a5600 Compare December 4, 2025 22:47
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from 533c465 to 81d703c Compare December 4, 2025 22:47
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from 87a5600 to 8f16f7a Compare December 5, 2025 01:53
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch 2 times, most recently from a81e889 to 86d3812 Compare December 8, 2025 23:41
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch 2 times, most recently from a526425 to 44309e3 Compare December 9, 2025 01:48
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from 86d3812 to 2c21828 Compare December 9, 2025 01:48
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from 44309e3 to d385e99 Compare December 9, 2025 02:07
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch 2 times, most recently from 869f4cf to 6dd07d1 Compare December 9, 2025 02:09
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from d385e99 to 66a011a Compare December 9, 2025 02:09
@camielvs camielvs mentioned this pull request Dec 9, 2025
Merged
3 tasks
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch 2 times, most recently from db9d2a2 to 8bc2c30 Compare December 10, 2025 00:10
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch 2 times, most recently from 17b4f45 to f57fb5d Compare December 10, 2025 00:14
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from 8bc2c30 to 1728b26 Compare December 10, 2025 00:14
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from f57fb5d to 1d45169 Compare December 10, 2025 00:40
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch 2 times, most recently from aa47905 to 8a01b0d Compare December 10, 2025 21:28
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from 1d45169 to 1cb8f58 Compare December 10, 2025 21:28
@camielvs camielvs mentioned this pull request Dec 10, 2025
Open
3 tasks
@camielvs camielvs requested a review from Mbeaulne December 15, 2025 21:15
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from c063c0a to d93cd57 Compare December 17, 2025 19:02
@camielvs camielvs requested a review from a team as a code owner December 17, 2025 19:02
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from b169ef9 to 80a0367 Compare December 17, 2025 19:02
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from d93cd57 to da65e9c Compare December 17, 2025 20:32
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch 2 times, most recently from 8aed7ce to da919d7 Compare December 17, 2025 20:34
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from da65e9c to abf1484 Compare December 17, 2025 20:34
maxy-shpfy
maxy-shpfy reviewed Dec 18, 2025
View reviewed changes
maxy-shpfy
maxy-shpfy reviewed Dec 18, 2025
View reviewed changes
maxy-shpfy
maxy-shpfy reviewed Dec 18, 2025
View reviewed changes
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from da919d7 to d36c503 Compare December 18, 2025 16:03
@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from abf1484 to 49b752e Compare December 18, 2025 16:03
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from d36c503 to 6630e43 Compare December 18, 2025 16:10
maxy-shpfy
maxy-shpfy reviewed Dec 18, 2025
View reviewed changes
src/components/shared/TaskDetails/Details.tsx
<ExecutionDetails
executionId={executionId}
componentSpec={componentSpec}
className="px-3 py-2"
Copy link
Collaborator

@maxy-shpfy maxy-shpfy Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future: another case for primitive like Surface

maxy-shpfy
maxy-shpfy approved these changes Dec 18, 2025
View reviewed changes
Copy link
Collaborator

@maxy-shpfy maxy-shpfy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

IMO: Visually header of the section previously was bold. To me that looks better - distinguishing the title.

@camielvs Graphite App
Copy link
Collaborator Author

camielvs commented Dec 18, 2025

^ true, although this runs on our default Header styles, so that would suggest they are not sufficient. it will be easy to change so let's look at it separately

@camielvs camielvs force-pushed the 12-04-add_ui_blocks_to_context_panel branch from 49b752e to a8add58 Compare December 18, 2025 19:28
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from 6630e43 to 87a8b15 Compare December 18, 2025 19:28
@camielvs camielvs changed the base branch from 12-04-add_ui_blocks_to_context_panel to graphite-base/1471 December 18, 2025 20:34
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from 87a8b15 to 0bf0e98 Compare December 18, 2025 20:34
@graphite-app graphite-app bot changed the base branch from graphite-base/1471 to master December 18, 2025 20:34
@camielvs camielvs force-pushed the 12-04-cleanup_executiondetails branch from 0bf0e98 to 9c9af85 Compare December 18, 2025 20:35
@camielvs Graphite App
Copy link
Collaborator Author

camielvs commented Dec 18, 2025 •
edited
Loading

Merge activity

  • Dec 18, 8:41 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 18, 8:42 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs merged commit 14f0476 into master Dec 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morgan-wowk morgan-wowk morgan-wowk approved these changes

@maxy-shpfy maxy-shpfy maxy-shpfy approved these changes

@Mbeaulne Mbeaulne Awaiting requested review from Mbeaulne

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camielvs @morgan-wowk @maxy-shpfy