Rework Run Action Buttons into Action Framework #1524
+882
−980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2025
Merged
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 10, 2025
Merged
Merged
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
8737a95 to
73c5435
Compare
camielvs
changed the base branch from
12-09-cleanup_rundetails
to
graphite-base/1524
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
73c5435 to
f5b8ed7
Compare
camielvs
changed the base branch from
graphite-base/1524
to
12-10-rework_codeviewer_implementation
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
f5b8ed7 to
0fdda14
Compare
camielvs
changed the title
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
0fdda14 to
6ac7507
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
1dd8730 to
0e92bae
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
2 times, most recently
from
f1367b4 to
1c75c23
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
0e92bae to
19707ab
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
1c75c23 to
22fcc25
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
19707ab to
726344b
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
22fcc25 to
19bc578
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
726344b to
5b89d37
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
19bc578 to
f8982e3
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
5b89d37 to
5f2112e
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
f8982e3 to
442d3d8
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
5f2112e to
0d02f62
Compare
3 tasks
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
442d3d8 to
b5bc3a7
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
0d02f62 to
1714799
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
f0775a7 to
e56a33a
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
2 times, most recently
from
cd10655 to
d4c116a
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
9212073 to
e92bc36
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
d4c116a to
43689aa
Compare
maxy-shpfy
reviewed
Dec 18, 2025
Comment on lines
+207
to
+211
| return { | ||
| actions, | ||
| isYamlFullscreen, | ||
| handleCloseYaml, | ||
| }; |
Collaborator
There was a problem hiding this comment.
I'm against grouping actions into one hook. It is much better create multiple hooks or use useQuery and useMutation within specific components.
maxy-shpfy
requested changes
Dec 18, 2025
Collaborator
maxy-shpfy
left a comment
maxy-shpfy
left a comment
There was a problem hiding this comment.
I'm against grouping actions into one hook. It is much better create multiple hooks or use useQuery and useMutation within specific components.
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
e92bc36 to
8c926e9
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
43689aa to
1b8d745
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
8c926e9 to
bb051b9
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
1b8d745 to
0b78866
Compare
Collaborator
Author
|
Hmmm. The idea was to split out the logic from the UI, and improve readability + testability. I'm open to ideas - let's discuss in the New Year |
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
0b78866 to
6759ff2
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
bb051b9 to
07f6759
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
6759ff2 to
17a86e0
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
2 times, most recently
from
176371b to
9d0f76f
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
17a86e0 to
77f593f
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
9d0f76f to
5fe4a59
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
77f593f to
57ea5aa
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
5fe4a59 to
c929346
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
57ea5aa to
f6b8aa2
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
c929346 to
a5ce09e
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
f6b8aa2 to
b98cf0e
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
from
a5ce09e to
47f036b
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
b98cf0e to
f0ad36d
Compare
camielvs
force-pushed
the
12-10-rework_codeviewer_implementation
branch
2 times, most recently
from
661532b to
eba55a1
Compare
camielvs
force-pushed
the
12-10-rework_action_buttons_into_new_action_framework
branch
from
f0ad36d to
dd65777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Action buttons in RunDetails follow the Action type style (rather than passing a straight ReactNode e.g. styled button). This ensures consistency of the interface, and makes it easy to implement new actions later.
This change requires some rework of the various RunDetails Buttons and the TaskImplementation. To formulate the actions list a new
useRunActionshook was added. Tests for these components have been, similarly, moved into a new consolidated test file for the hook.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
No change to app functionality.
Confirm that all buttons in RunActions look consistent and continue to function as expected.
Additional Comments