forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 5
Rework Task Action Buttons into Action Framework #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
camielvs
wants to merge
1
commit into
12-10-rework_action_buttons_into_new_action_framework
Choose a base branch
from
12-11-rework_task_action_buttons_into_action_framework
base: 12-10-rework_action_buttons_into_new_action_framework
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rework Task Action Buttons into Action Framework #1534
camielvs
wants to merge
1
commit into
12-10-rework_action_buttons_into_new_action_framework
from
12-11-rework_task_action_buttons_into_action_framework
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2025
Merged
Merged
Merged
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
05a1298 to
fe07e23
Compare
442d3d8 to
b5bc3a7
Compare
ea15e3d to
4b7d2a6
Compare
b5bc3a7 to
92df4ce
Compare
4b7d2a6 to
f2cfc9c
Compare
3 tasks
92df4ce to
3f06300
Compare
f2cfc9c to
1173005
Compare
3f06300 to
b75cc60
Compare
1173005 to
b9aa264
Compare
3 tasks
b9aa264 to
cffdec7
Compare
b75cc60 to
ae93d35
Compare
cffdec7 to
bee2c49
Compare
ae93d35 to
876df26
Compare
bee2c49 to
e8e73c3
Compare
d26903d to
d036c24
Compare
011fc2c to
deac44d
Compare
64a6bf9 to
9693f27
Compare
3abf433 to
cd10655
Compare
9693f27 to
82c0f41
Compare
cd10655 to
d4c116a
Compare
82c0f41 to
5e4da0c
Compare
d4c116a to
43689aa
Compare
19fc8ca to
7430f0a
Compare
43689aa to
1b8d745
Compare
7430f0a to
753f9ca
Compare
0b78866 to
6759ff2
Compare
1ac8370 to
fcd7152
Compare
17a86e0 to
77f593f
Compare
fcd7152 to
0c93c21
Compare
77f593f to
57ea5aa
Compare
0c93c21 to
637352e
Compare
57ea5aa to
f6b8aa2
Compare
637352e to
b7e4b87
Compare
f6b8aa2 to
b98cf0e
Compare
b7e4b87 to
71fe8b0
Compare
b98cf0e to
f0ad36d
Compare
71fe8b0 to
b56a9fe
Compare
f0ad36d to
dd65777
Compare
b56a9fe to
ec678b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Moves all of the action buttons on the task card into the new ActionBlock
Actiontype for consistency of UI and implementation.This PR also tidies up where actions are defined. Previously they were scattered over various files. Now:
More specifically:
TaskNodeCard
TaskOverview
ComponentDetailsDialog
TaskActions
Due to this change the component editor action was moved to TaskAction (it is shared), allowing us to consolidate down to one implementation of the ComponentEditor, rather than two. Additionally, the View YAML action was moved from TaskOverview to colocate with other actions in TaskNodeCard. TaskOverview is now a pass-through component as far as actions are concerned.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
No change to app functionality.
Confirm that all buttons in TaskActions & ComponentDetailsDialog look consistent and continue to function as expected.
Additional Comments
Note: TaskOverview could do with a cleanup - this is not the PR for that.