Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Dec 11, 2025

Description

Moves all of the action buttons on the task card into the new ActionBlock Action type for consistency of UI and implementation.

This PR also tidies up where actions are defined. Previously they were scattered over various files. Now:

  • TaskNode actions are defined in TaskNodeCard
  • ComponentDetails actions are defined in ComponentDetailsDialog (currently none)
  • shared actions are in TaskActions

More specifically:

TaskNodeCard

  • Duplicate Task
  • Update from Source
  • Enter Subgraph
  • Edit Definition -> moved to TaskActions

TaskOverview

  • View YAML -> moved to TaskNodeCard

ComponentDetailsDialog

  • Edit Definition (again!) -> removed

TaskActions

  • Download YAML
  • Download Python
  • Copy YAML
  • Delete (if onDelete is provided)

Due to this change the component editor action was moved to TaskAction (it is shared), allowing us to consolidate down to one implementation of the ComponentEditor, rather than two. Additionally, the View YAML action was moved from TaskOverview to colocate with other actions in TaskNodeCard. TaskOverview is now a pass-through component as far as actions are concerned.

image.png

Related Issue and Pull requests

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

No change to app functionality.

Confirm that all buttons in TaskActions & ComponentDetailsDialog look consistent and continue to function as expected.

Additional Comments

Note: TaskOverview could do with a cleanup - this is not the PR for that.

Copy link
Collaborator Author

camielvs commented Dec 11, 2025

@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 05a1298 to fe07e23 Compare December 11, 2025 23:09
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 442d3d8 to b5bc3a7 Compare December 11, 2025 23:09
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch 2 times, most recently from ea15e3d to 4b7d2a6 Compare December 12, 2025 00:44
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from b5bc3a7 to 92df4ce Compare December 12, 2025 00:44
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 4b7d2a6 to f2cfc9c Compare December 12, 2025 00:52
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 92df4ce to 3f06300 Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from f2cfc9c to 1173005 Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 3f06300 to b75cc60 Compare December 13, 2025 00:23
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 1173005 to b9aa264 Compare December 13, 2025 00:23
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from b9aa264 to cffdec7 Compare December 15, 2025 20:20
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from b75cc60 to ae93d35 Compare December 15, 2025 20:20
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from cffdec7 to bee2c49 Compare December 15, 2025 20:25
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from ae93d35 to 876df26 Compare December 15, 2025 20:25
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from bee2c49 to e8e73c3 Compare December 15, 2025 20:38
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch 2 times, most recently from d26903d to d036c24 Compare December 15, 2025 20:43
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch 2 times, most recently from 011fc2c to deac44d Compare December 15, 2025 20:47
@camielvs camielvs requested review from Mbeaulne and removed request for a team December 17, 2025 19:14
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 64a6bf9 to 9693f27 Compare December 17, 2025 19:16
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 3abf433 to cd10655 Compare December 17, 2025 20:32
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 9693f27 to 82c0f41 Compare December 17, 2025 20:32
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from cd10655 to d4c116a Compare December 17, 2025 20:34
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 82c0f41 to 5e4da0c Compare December 17, 2025 20:34
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from d4c116a to 43689aa Compare December 17, 2025 20:56
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch 2 times, most recently from 19fc8ca to 7430f0a Compare December 18, 2025 16:03
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 43689aa to 1b8d745 Compare December 18, 2025 16:03
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 7430f0a to 753f9ca Compare December 18, 2025 16:10
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch 2 times, most recently from 0b78866 to 6759ff2 Compare December 18, 2025 19:28
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch 2 times, most recently from 1ac8370 to fcd7152 Compare December 18, 2025 19:34
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch 2 times, most recently from 17a86e0 to 77f593f Compare December 18, 2025 20:37
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from fcd7152 to 0c93c21 Compare December 18, 2025 20:38
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 77f593f to 57ea5aa Compare December 18, 2025 20:44
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 0c93c21 to 637352e Compare December 18, 2025 20:45
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 57ea5aa to f6b8aa2 Compare December 18, 2025 20:51
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 637352e to b7e4b87 Compare December 18, 2025 20:51
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from f6b8aa2 to b98cf0e Compare December 18, 2025 20:55
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from b7e4b87 to 71fe8b0 Compare December 18, 2025 20:56
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from b98cf0e to f0ad36d Compare December 18, 2025 20:59
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 71fe8b0 to b56a9fe Compare December 18, 2025 20:59
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from f0ad36d to dd65777 Compare December 18, 2025 21:03
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from b56a9fe to ec678b4 Compare December 18, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants