Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Dec 12, 2025

Description

Reworks the PipelineDetails action buttons to move them to the new ActionBlock framework. This requires reworking how RenamePipeline works, resulting in the component being deleted and the logic being moved to PipelineDetails. To enable this PipelineNameDialog was reworked to allow for either controlled state (as used in the new framework) or uncontrolled (as used in the existing FileActions - SaveAs implementation). In future we may unify so the component is only controlled, but that is not for this PR.

This PR marks the last items that need to be moved into the ActionBlock framework, so the temporary ActionOrReactNode type has been removed - all future additions to an ActionBlock must be defined as a purely Action type.

Related Issue and Pull requests

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

No change to app functionality.

Confirm that all buttons in PipelineActions look consistent and continue to function as expected.

Additional Comments

Copy link
Collaborator Author

camielvs commented Dec 12, 2025

@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from d9fb92d to e9b7d36 Compare December 12, 2025 19:36
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from f2cfc9c to 1173005 Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from e9b7d36 to 2f7c337 Compare December 12, 2025 22:08
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 1173005 to b9aa264 Compare December 13, 2025 00:23
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from 2f7c337 to 8e17e54 Compare December 13, 2025 00:23
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from b9aa264 to cffdec7 Compare December 15, 2025 20:20
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from 8e17e54 to c76d205 Compare December 15, 2025 20:20
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from cffdec7 to bee2c49 Compare December 15, 2025 20:25
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from c76d205 to 5541984 Compare December 15, 2025 20:25
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from bee2c49 to e8e73c3 Compare December 15, 2025 20:38
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch 2 times, most recently from a19e1dd to cd5b6c8 Compare December 15, 2025 20:43
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch 2 times, most recently from 011fc2c to deac44d Compare December 15, 2025 20:47
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch 2 times, most recently from 840bab4 to f3bd2dd Compare December 17, 2025 19:02
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from deac44d to 64a6bf9 Compare December 17, 2025 19:02
@camielvs camielvs marked this pull request as ready for review December 17, 2025 19:14
@camielvs camielvs requested a review from a team as a code owner December 17, 2025 19:14
@camielvs camielvs requested review from Mbeaulne and removed request for a team December 17, 2025 19:14
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 64a6bf9 to 9693f27 Compare December 17, 2025 19:16
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch 3 times, most recently from ead2ea1 to d653f9f Compare December 17, 2025 20:34
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 82c0f41 to 5e4da0c Compare December 17, 2025 20:34
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from d653f9f to 2b11111 Compare December 17, 2025 20:56
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch 2 times, most recently from 19fc8ca to 7430f0a Compare December 18, 2025 16:03
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch 2 times, most recently from 6e0d5b2 to bb88a3d Compare December 18, 2025 16:10
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch 2 times, most recently from 753f9ca to 1ac8370 Compare December 18, 2025 19:28
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from bb88a3d to 6a46448 Compare December 18, 2025 19:28
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 1ac8370 to fcd7152 Compare December 18, 2025 19:34
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from 6a46448 to 8089476 Compare December 18, 2025 19:34
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from fcd7152 to 0c93c21 Compare December 18, 2025 20:38
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from 8089476 to 7bd5cd0 Compare December 18, 2025 20:38
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 0c93c21 to 637352e Compare December 18, 2025 20:45
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from 7bd5cd0 to e817546 Compare December 18, 2025 20:46
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 637352e to b7e4b87 Compare December 18, 2025 20:51
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from e817546 to e0e1d2a Compare December 18, 2025 20:52
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from b7e4b87 to 71fe8b0 Compare December 18, 2025 20:56
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from e0e1d2a to 17301a5 Compare December 18, 2025 20:56
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from 71fe8b0 to b56a9fe Compare December 18, 2025 20:59
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from 17301a5 to b32a55f Compare December 18, 2025 20:59
@camielvs camielvs force-pushed the 12-11-rework_task_action_buttons_into_action_framework branch from b56a9fe to ec678b4 Compare December 18, 2025 21:03
@camielvs camielvs force-pushed the 12-12-rework_pipeline_action_buttons_into_action_framework branch from b32a55f to 7c248f0 Compare December 18, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants