forked from Cloud-Pipelines/pipeline-editor
-
Notifications
You must be signed in to change notification settings - Fork 5
Rework Pipeline Action Buttons into Action Framework #1544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
camielvs
wants to merge
1
commit into
12-11-rework_task_action_buttons_into_action_framework
Choose a base branch
from
12-12-rework_pipeline_action_buttons_into_action_framework
base: 12-11-rework_task_action_buttons_into_action_framework
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rework Pipeline Action Buttons into Action Framework #1544
camielvs
wants to merge
1
commit into
12-11-rework_task_action_buttons_into_action_framework
from
12-12-rework_pipeline_action_buttons_into_action_framework
+138
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 12, 2025
Merged
Merged
Merged
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
d9fb92d to
e9b7d36
Compare
f2cfc9c to
1173005
Compare
e9b7d36 to
2f7c337
Compare
1173005 to
b9aa264
Compare
2f7c337 to
8e17e54
Compare
3 tasks
b9aa264 to
cffdec7
Compare
8e17e54 to
c76d205
Compare
cffdec7 to
bee2c49
Compare
c76d205 to
5541984
Compare
bee2c49 to
e8e73c3
Compare
a19e1dd to
cd5b6c8
Compare
011fc2c to
deac44d
Compare
840bab4 to
f3bd2dd
Compare
deac44d to
64a6bf9
Compare
64a6bf9 to
9693f27
Compare
ead2ea1 to
d653f9f
Compare
82c0f41 to
5e4da0c
Compare
d653f9f to
2b11111
Compare
19fc8ca to
7430f0a
Compare
6e0d5b2 to
bb88a3d
Compare
753f9ca to
1ac8370
Compare
bb88a3d to
6a46448
Compare
1ac8370 to
fcd7152
Compare
6a46448 to
8089476
Compare
fcd7152 to
0c93c21
Compare
8089476 to
7bd5cd0
Compare
0c93c21 to
637352e
Compare
7bd5cd0 to
e817546
Compare
637352e to
b7e4b87
Compare
e817546 to
e0e1d2a
Compare
b7e4b87 to
71fe8b0
Compare
e0e1d2a to
17301a5
Compare
71fe8b0 to
b56a9fe
Compare
17301a5 to
b32a55f
Compare
b56a9fe to
ec678b4
Compare
b32a55f to
7c248f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
Reworks the PipelineDetails action buttons to move them to the new ActionBlock framework. This requires reworking how RenamePipeline works, resulting in the component being deleted and the logic being moved to PipelineDetails. To enable this PipelineNameDialog was reworked to allow for either controlled state (as used in the new framework) or uncontrolled (as used in the existing FileActions - SaveAs implementation). In future we may unify so the component is only controlled, but that is not for this PR.
This PR marks the last items that need to be moved into the ActionBlock framework, so the temporary
ActionOrReactNodetype has been removed - all future additions to an ActionBlock must be defined as a purely Action type.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
No change to app functionality.
Confirm that all buttons in PipelineActions look consistent and continue to function as expected.
Additional Comments