Skip to content

Conversation

@camielvs
Copy link
Collaborator

@camielvs camielvs commented Dec 10, 2025

Description

Rework the codeviewer so the fullscreen button is not embedded into the CodeViewer component itself, and change the CodeViewer component to be controlled rather than uncontrolled. it now focusses purely on displaying code inline or fullscreen, and does not concern itself with its triggering button.

Toggling functionality is moved to the TaskImplementation component, allowing the CodeViewer to be used without specifically requiring a button (i.e. it can be controlled programmatically). As such, this requires a slightly more manual implementation across current CodeViewer usage.

This then allows the TaskImplementation action to be reworked into a TooltipButton, and then, further upstack, into an Action object.

Note: I didn't want to get bogged down with trying to move all the divs in CodeViewer onto BlockStack. I feel that given it's a bespoke component it's probably okay for now to leave as-is.

Related Issue and Pull requests

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

No change to app functionality. Code architecture update only. Confirm that the CodeViewer still behaves as expected.

Test Instructions

Additional Comments

@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 541ae4c to dd7fc57 Compare December 10, 2025 22:50
@camielvs camielvs force-pushed the 12-10-rework_action_buttons_into_new_action_framework branch from 8737a95 to 73c5435 Compare December 10, 2025 22:50
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch 3 times, most recently from 13b3154 to a243c75 Compare December 10, 2025 23:31
@camielvs camielvs changed the base branch from 12-10-rework_action_buttons_into_new_action_framework to graphite-base/1527 December 10, 2025 23:40
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from a243c75 to 1139464 Compare December 10, 2025 23:41
@camielvs camielvs changed the base branch from graphite-base/1527 to 12-09-cleanup_rundetails December 10, 2025 23:41
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 73e7131 to 2a0ccca Compare December 11, 2025 00:23
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 1139464 to 1dd8730 Compare December 11, 2025 00:23
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 2a0ccca to f8e3134 Compare December 11, 2025 00:34
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 1dd8730 to 0e92bae Compare December 11, 2025 00:34
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from f8e3134 to e677909 Compare December 11, 2025 00:36
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch 2 times, most recently from 19707ab to 726344b Compare December 11, 2025 00:51
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch 2 times, most recently from 65234bf to 7617cac Compare December 11, 2025 00:56
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 726344b to 5b89d37 Compare December 11, 2025 00:56
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 7617cac to c74095b Compare December 11, 2025 01:02
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch 2 times, most recently from 5f2112e to 0d02f62 Compare December 11, 2025 20:26
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch 2 times, most recently from b4cba19 to 0b935ab Compare December 17, 2025 20:34
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch 2 times, most recently from 9212073 to e92bc36 Compare December 17, 2025 20:56
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 0b935ab to fe12b7a Compare December 17, 2025 20:56
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from e92bc36 to 8c926e9 Compare December 18, 2025 16:03
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from fe12b7a to 13f4c81 Compare December 18, 2025 16:03
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 8c926e9 to bb051b9 Compare December 18, 2025 16:10
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch 2 times, most recently from 105e9f7 to 46cbbb5 Compare December 18, 2025 19:28
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from bb051b9 to 07f6759 Compare December 18, 2025 19:28
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 46cbbb5 to 2455eff Compare December 18, 2025 19:34
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 07f6759 to 176371b Compare December 18, 2025 19:34
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 2455eff to 2466b3a Compare December 18, 2025 20:36
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 176371b to 9d0f76f Compare December 18, 2025 20:36
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 2466b3a to 6d6c600 Compare December 18, 2025 20:43
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 9d0f76f to 5fe4a59 Compare December 18, 2025 20:44
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from 6d6c600 to afce81c Compare December 18, 2025 20:50
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 5fe4a59 to c929346 Compare December 18, 2025 20:50
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch 2 times, most recently from 6f754e0 to ed9558d Compare December 18, 2025 20:55
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch 2 times, most recently from a5ce09e to 47f036b Compare December 18, 2025 20:59
@camielvs camielvs force-pushed the 12-09-cleanup_rundetails branch from ed9558d to 1bccc0a Compare December 18, 2025 20:59
@camielvs camielvs changed the base branch from 12-09-cleanup_rundetails to graphite-base/1527 December 18, 2025 21:01
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 47f036b to 661532b Compare December 18, 2025 21:02
@graphite-app graphite-app bot changed the base branch from graphite-base/1527 to master December 18, 2025 21:02
@camielvs camielvs force-pushed the 12-10-rework_codeviewer_implementation branch from 661532b to eba55a1 Compare December 18, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants