Cleanup RunDetails #1508
Merged
Cleanup RunDetails #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2025
Merged
Collaborator
Author
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
357c105 to
4f1da94
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
8a732e2 to
043bd18
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
4f1da94 to
c9f9463
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
2 times, most recently
from
b4df554 to
68f0eb0
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
c9f9463 to
bf46c51
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
2 times, most recently
from
12baeb2 to
7f0da59
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
bf46c51 to
2ef9e9e
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
7f0da59 to
15bad0b
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
2ef9e9e to
3464c13
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
15bad0b to
2573d44
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
2 times, most recently
from
500ca6f to
c135e7f
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
2573d44 to
73e7131
Compare
This was referenced Dec 10, 2025
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
c135e7f to
d0edb0b
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
2 times, most recently
from
2a0ccca to
f8e3134
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
d0edb0b to
887c783
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
2 times, most recently
from
e677909 to
65234bf
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
4d838bd to
cdd5672
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
2 times, most recently
from
0b935ab to
fe12b7a
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
2 times, most recently
from
6a78b72 to
fadfee9
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
fe12b7a to
13f4c81
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
fadfee9 to
ac114e5
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
13f4c81 to
105e9f7
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
ac114e5 to
ee9d94e
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
105e9f7 to
46cbbb5
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
ee9d94e to
ff73971
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
46cbbb5 to
2455eff
Compare
Collaborator
|
I liked the padding between Title and content (e.g. in "Run Info", no it is too close to the content). |
maxy-shpfy
approved these changes
Dec 18, 2025
Collaborator
maxy-shpfy
left a comment
maxy-shpfy
left a comment
There was a problem hiding this comment.
LGTM, I would increase the distance between Title and Content, but not blocking the PR
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
ff73971 to
e5c8c47
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
2455eff to
2466b3a
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
from
e5c8c47 to
78723bb
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
2466b3a to
6d6c600
Compare
camielvs
force-pushed
the
12-03-cleanup_pipelinedetails
branch
2 times, most recently
from
31883ac to
316385c
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
6d6c600 to
afce81c
Compare
camielvs
changed the base branch from
12-03-cleanup_pipelinedetails
to
graphite-base/1508
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
afce81c to
6f754e0
Compare
camielvs
force-pushed
the
graphite-base/1508
branch
from
316385c to
05f8f61
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
6f754e0 to
ed9558d
Compare
camielvs
force-pushed
the
12-09-cleanup_rundetails
branch
from
ed9558d to
1bccc0a
Compare
Collaborator
Author
Collaborator
Author
Ah, I missed this comment before merging. Let's grab it in a follow-up in the new year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RunDetails recently got a good cleanup, so this PR focusses mostly on bringing it over to the ContextPanel Block system for improved visual consistency.
Functionality of the ArtifactsList is already moved to PipelineIO, so this last implementation of it has been removed along with the component itself. PipelineIO has now been moved to a more generic
Executionfolder, where, in future, we can put more execution-related UI components.Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/401
Type of Change
Checklist
Screenshots (if applicable)
Before:
After:
Test Instructions
No change to app functionality. UI update only. Confirm that the interface works and shows info as expected.
Additional Comments