Skip to content

refactor: remove fetchFavoriteComponents method #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxy-shpfy merged 1 commit into from
Dec 18, 2025
Merged

refactor: remove fetchFavoriteComponents method #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/providers/ComponentLibraryProvider/ComponentLibraryProvider.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ const mockFetchUserComponents = vi.mocked(
const mockFetchUsedComponents = vi.mocked(
componentLibraryUtils.fetchUsedComponents,
);
const mockFetchFavoriteComponents = vi.mocked(
componentLibraryUtils.fetchFavoriteComponents,
);
const mockPopulateComponentRefs = vi.mocked(
componentLibraryUtils.populateComponentRefs,
);
Expand Down Expand Up @@ -149,11 +146,6 @@ describe("ComponentLibraryProvider - Component Management", () => {
components: [],
folders: [],
});
mockFetchFavoriteComponents.mockReturnValue({
name: "Favorites",
components: [],
folders: [],
});
mockPopulateComponentRefs.mockImplementation((lib) => Promise.resolve(lib));
mockFlattenFolders.mockImplementation((folder) => {
if ("folders" in folder) {
Expand Down
84 changes: 0 additions & 84 deletions src/providers/ComponentLibraryProvider/componentLibrary.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import * as localforage from "@/utils/localforage";
import * as yamlUtils from "@/utils/yaml";

import {
fetchFavoriteComponents,
fetchUsedComponents,
fetchUserComponents,
filterToUniqueByDigest,
Expand Down Expand Up @@ -261,89 +260,6 @@ describe("componentLibrary", () => {
// todo: test with deeply nested task structures
});

describe("fetchFavoriteComponents", () => {
const mockComponentLibrary: ComponentLibrary = {
folders: [
{
name: "Folder 1",
components: [
{
name: "component-1",
digest: "digest1",
favorited: true,
},
{
name: "component-2",
digest: "digest2",
favorited: false,
},
],
folders: [
{
name: "Subfolder",
components: [
{
name: "component-3",
digest: "digest3",
favorited: true,
},
],
folders: [],
},
],
},
],
};

it("should return favorited components from library", () => {
// Act
const result = fetchFavoriteComponents(mockComponentLibrary);

// Assert
expect(result).toEqual({
name: "Favorite Components",
components: [
{
name: "component-1",
digest: "digest1",
favorited: true,
},
{
name: "component-3",
digest: "digest3",
favorited: true,
},
],
folders: [],
isUserFolder: false,
});
});

it("should return empty folder when no component library provided", () => {
// Act
const result = fetchFavoriteComponents(undefined);

// Assert
expect(result).toEqual({
name: "Favorite Components",
components: [],
folders: [],
isUserFolder: false,
});
});

it("should work without user components", () => {
// Act
const result = fetchFavoriteComponents(mockComponentLibrary);

// Assert
expect(result.components).toHaveLength(2);
expect(result.components?.every((c) => c.favorited)).toBe(true);
});

// todo: test deduplication of favorites with same digest across library and user components
});

describe("populateComponentRefs", () => {
beforeEach(() => {
mockComponentService.parseComponentData.mockImplementation(
Expand Down
30 changes: 0 additions & 30 deletions src/providers/ComponentLibraryProvider/componentLibrary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,36 +90,6 @@ export async function isFavoriteComponent(component: ComponentReference) {
return storedComponent?.favorited ?? false;
}

/**
* @deprecated
*/
export const fetchFavoriteComponents = (
componentLibrary: ComponentLibrary | undefined,
): ComponentFolder => {
const favoritesFolder = {
name: "Favorite Components",
components: [] as ComponentReference[],
folders: [],
isUserFolder: false,
};

if (!componentLibrary || !componentLibrary.folders) {
return favoritesFolder;
}

const uniqueLibraryComponents = filterToUniqueByDigest(
flattenFolders(componentLibrary),
);

uniqueLibraryComponents.forEach((component) => {
if (component?.favorited) {
favoritesFolder.components.push(component);
}
});

return favoritesFolder;
};

export async function populateComponentRefs<
T extends ComponentLibrary | ComponentFolder,
>(libraryOrFolder: T): Promise<T> {
Expand Down
Loading