refactor: remove fetchFavoriteComponents method #1561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2025
Collaborator
Author
8 tasks
maxy-shpfy
changed the title
This was referenced Dec 16, 2025
Mbeaulne
approved these changes
Dec 17, 2025
This was referenced Dec 17, 2025
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
from
36bc459 to
db9e4b3
Compare
maxy-shpfy
force-pushed
the
12-15-feat_remove_fetchfavoritecomponents_method
branch
from
3930ad6 to
42a8153
Compare
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
from
db9e4b3 to
66e347b
Compare
maxy-shpfy
force-pushed
the
12-15-feat_remove_fetchfavoritecomponents_method
branch
from
42a8153 to
820c277
Compare
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
from
66e347b to
b62d6e8
Compare
maxy-shpfy
force-pushed
the
12-15-feat_remove_fetchfavoritecomponents_method
branch
from
820c277 to
b7f156e
Compare
4 tasks
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
from
b62d6e8 to
be7a59d
Compare
maxy-shpfy
force-pushed
the
12-15-feat_remove_fetchfavoritecomponents_method
branch
from
b7f156e to
b48a8d4
Compare
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
2 times, most recently
from
68c4190 to
59ef157
Compare
maxy-shpfy
force-pushed
the
12-15-feat_remove_fetchfavoritecomponents_method
branch
from
b48a8d4 to
fa50b1f
Compare
maxy-shpfy
changed the base branch from
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
to
graphite-base/1561
maxy-shpfy
force-pushed
the
12-15-feat_remove_fetchfavoritecomponents_method
branch
from
fa50b1f to
3403198
Compare
maxy-shpfy
force-pushed
the
graphite-base/1561
branch
from
59ef157 to
b856ef0
Compare
maxy-shpfy
force-pushed
the
12-15-feat_remove_fetchfavoritecomponents_method
branch
from
3403198 to
93df13e
Compare
Collaborator
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the deprecated
fetchFavoriteComponentsfunction and its related test cases. This function was previously marked as deprecated and is no longer needed in the codebase.Type of Change
Checklist
Test Instructions
Verify that the application still functions correctly without the removed function, particularly in areas that might have previously used the favorites functionality.