refactor: remove checkIfFavorited from ComponentLibraryProvider #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Collaborator
Author
8 tasks
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
from
e32777b to
36bc459
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
b2cf0e0 to
c12e371
Compare
This was referenced Dec 16, 2025
Mbeaulne
approved these changes
Dec 17, 2025
This was referenced Dec 17, 2025
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
from
36bc459 to
db9e4b3
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
2 times, most recently
from
b2e6655 to
838ef5c
Compare
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
2 times, most recently
from
66e347b to
b62d6e8
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
838ef5c to
1d63324
Compare
4 tasks
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
1d63324 to
26f27d1
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
26f27d1 to
43b189e
Compare
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
from
b62d6e8 to
be7a59d
Compare
maxy-shpfy
changed the base branch from
12-15-feat_lazy_load_of_the_yaml_library_components
to
graphite-base/1559
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
from
be7a59d to
68c4190
Compare
maxy-shpfy
force-pushed
the
graphite-base/1559
branch
from
43b189e to
04bd333
Compare
maxy-shpfy
force-pushed
the
12-15-refactor_remove_checkiffavorited_from_componentlibraryprovider
branch
from
68c4190 to
59ef157
Compare
Collaborator
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the deprecated
checkIfFavoritedmethod from the ComponentLibraryProvider. This includes:Type of Change
Checklist
Test Instructions
Ensure that no components are using the deprecated
checkIfFavoritedmethod. All components should be updated to use alternative methods for checking if a component is favorited.