Skip to content

refactor: remove unsused props from componentLibraryProvider #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxy-shpfy merged 1 commit into from
Dec 18, 2025
Merged

refactor: remove unsused props from componentLibraryProvider #1563

maxy-shpfy merged 1 commit into from
Dec 18, 2025

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Dec 16, 2025 •
edited
Loading

Description

Removed unused refetchLibrary and refetchUserComponents methods from the ComponentLibraryProvider context and its mock in tests. These methods were defined in the context type but are no longer needed.

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

Verify that component library functionality continues to work as expected without the removed refetch methods.

This was referenced Dec 16, 2025
Merged
Merged
Merged
Merged
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Dec 16, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy mentioned this pull request Dec 16, 2025
Merged
3 tasks
@maxy-shpfy maxy-shpfy marked this pull request as ready for review December 16, 2025 06:06
This was referenced Dec 16, 2025
Draft
Draft
This was referenced Dec 17, 2025
Open
Draft
Draft
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_highlighted_state_from_componentlibraryprovider branch from 6a14c0c to f4069ff Compare December 17, 2025 19:05
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_unsused_props_from_componentlibraryprovider branch from 52688cd to d1d0ffa Compare December 17, 2025 19:05
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_highlighted_state_from_componentlibraryprovider branch from f4069ff to f38dfcf Compare December 17, 2025 19:16
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_unsused_props_from_componentlibraryprovider branch from d1d0ffa to 499ca85 Compare December 17, 2025 19:16
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_highlighted_state_from_componentlibraryprovider branch from f38dfcf to 308a3cf Compare December 17, 2025 19:21
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_unsused_props_from_componentlibraryprovider branch from 499ca85 to 9afbd92 Compare December 17, 2025 19:21
@maxy-shpfy maxy-shpfy mentioned this pull request Dec 18, 2025
Draft
4 tasks
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_highlighted_state_from_componentlibraryprovider branch from 308a3cf to da31a13 Compare December 18, 2025 16:56
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner December 18, 2025 16:56
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_unsused_props_from_componentlibraryprovider branch from 9afbd92 to 37ad5c1 Compare December 18, 2025 16:56
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_highlighted_state_from_componentlibraryprovider branch from da31a13 to 49b90f1 Compare December 18, 2025 17:53
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_unsused_props_from_componentlibraryprovider branch from 37ad5c1 to 322e1b5 Compare December 18, 2025 17:54
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_highlighted_state_from_componentlibraryprovider branch from 49b90f1 to 7f3e8ec Compare December 18, 2025 18:00
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_unsused_props_from_componentlibraryprovider branch from 322e1b5 to c12b240 Compare December 18, 2025 18:00
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_highlighted_state_from_componentlibraryprovider branch from 7f3e8ec to cf44015 Compare December 18, 2025 18:07
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_highlighted_state_from_componentlibraryprovider branch from cf44015 to 30e21ec Compare December 18, 2025 18:08
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_unsused_props_from_componentlibraryprovider branch from c12b240 to d9d756b Compare December 18, 2025 18:08
@maxy-shpfy maxy-shpfy changed the base branch from 12-15-refactor_remove_highlighted_state_from_componentlibraryprovider to graphite-base/1563 December 18, 2025 18:26
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_unsused_props_from_componentlibraryprovider branch from d9d756b to d4135ef Compare December 18, 2025 18:27
@graphite-app graphite-app bot changed the base branch from graphite-base/1563 to master December 18, 2025 18:27
@maxy-shpfy maxy-shpfy force-pushed the 12-15-refactor_remove_unsused_props_from_componentlibraryprovider branch from d4135ef to cc2648a Compare December 18, 2025 18:28
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Dec 18, 2025 •
edited
Loading

Merge activity

  • Dec 18, 6:32 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 18, 6:32 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit d322699 into master Dec 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mbeaulne Mbeaulne Mbeaulne approved these changes

@camielvs camielvs Awaiting requested review from camielvs

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxy-shpfy @Mbeaulne