feat: lazy load of the yaml library components #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
4 tasks
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
b269a5c to
9483667
Compare
maxy-shpfy
force-pushed
the
12-15-feat_hydrate_component_library_file
branch
2 times, most recently
from
c7cb823 to
5d85020
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
2 times, most recently
from
06d72a6 to
ef2a39e
Compare
maxy-shpfy
force-pushed
the
12-15-feat_hydrate_component_library_file
branch
from
5d85020 to
14cf3eb
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
ef2a39e to
b2cf0e0
Compare
4 tasks
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
b2cf0e0 to
c12e371
Compare
3 tasks
This was referenced Dec 16, 2025
Mbeaulne
reviewed
Dec 17, 2025
src/providers/ComponentLibraryProvider/ComponentLibraryProvider.tsx
Outdated
Show resolved
Hide resolved
This was referenced Dec 17, 2025
maxy-shpfy
force-pushed
the
12-15-feat_hydrate_component_library_file
branch
from
14cf3eb to
d437913
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
2 times, most recently
from
b2e6655 to
838ef5c
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
838ef5c to
1d63324
Compare
Mbeaulne
approved these changes
Dec 17, 2025
4 tasks
maxy-shpfy
changed the base branch from
12-15-feat_hydrate_component_library_file
to
graphite-base/1556
maxy-shpfy
force-pushed
the
graphite-base/1556
branch
from
d437913 to
2d10327
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
1d63324 to
26f27d1
Compare
maxy-shpfy
force-pushed
the
12-15-feat_lazy_load_of_the_yaml_library_components
branch
from
26f27d1 to
43b189e
Compare
Collaborator
Author
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1306
Contributes to https://github.com/Shopify/oasis-frontend/issues/249
Removed the
populateComponentRefsfunction call when setting the component library state. Also removed thestoreComponentsFromLibraryfunction and its associated logic that was storing individual components in local storage.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Screen Recording 2025-12-15 at 4.42.24 PM.mov (uploaded via Graphite)
In the video I manually removed "hydration" info (name, author, digest) from the "Quick start" folder to ensure, that Left panel can display "not loaded" libraries.
Additional Comments
This change simplifies the component library loading process by removing unnecessary processing steps.