Conversation
Hannahjjj97
requested changes
Jan 29, 2026
| public ShooterSubsystem() {} | ||
|
|
||
| private void shoot() { | ||
| private final PWMSparkMax shooter = new PWMSparkMax(0); |
Contributor
There was a problem hiding this comment.
我們用的是 CAN 訊號的 sparkMAX 喔
所以應該是 SparkMax 這個類別
Contributor
|
阿你如果改完了 要再 request review 一次喔 |
Hannahjjj97
requested changes
Jan 29, 2026
Contributor
Hannahjjj97
left a comment
Hannahjjj97
left a comment
There was a problem hiding this comment.
你的 commit message 沒有照規定喔
需修正
Hannahjjj97
requested changes
Jan 29, 2026
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 |
Contributor
commit message 如果很難修正就算了，但下次記得照規定 |
BrianHu0925
reviewed
Feb 1, 2026
| public ShooterSubsystem() {} | ||
|
|
||
| private void shoot() { | ||
| private final SparkMax shooter = new SparkMax(0, null); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shooter的初版程式