Skip to content

Conversation

@teo-tsirpanis
Copy link
Member

Fixes CORE-441. This will enable faster acquisiotion of new TileDB.Native versions, without needing to release a new TileDB.CSharp version.

@gemini-code-assist
Copy link

Summary of Changes

Hello @teo-tsirpanis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the dependency management for the TileDB.Native package by removing its upper version constraint. The primary goal is to facilitate a more agile integration of new TileDB.Native releases into TileDB.CSharp, ensuring that the project can leverage the latest native library features and fixes without requiring a synchronous release cycle for the C# wrapper.

Highlights

  • Dependency Versioning: The explicit upper bound on the TileDB.Native package dependency has been removed, changing its specification from a strict range to a minimum version.
  • Faster Updates: This modification enables TileDB.CSharp to automatically acquire newer TileDB.Native versions as they become available, without necessitating a new TileDB.CSharp release for each update.
  • Issue Resolution: This change addresses and fixes the issue identified as CORE-441.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to remove the upper version bound for the TileDB.Native package dependency to allow for faster adoption of new native library versions. However, the current change pins the dependency to the exact version 2.30.0, which is contrary to the intended goal. My review includes a critical comment with a suggested fix to use a floating version range [2.30.0,), which correctly removes the upper bound and will allow consumers to use any version from 2.30.0 onwards.

<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<TileDBNativePackageName>TileDB.Native</TileDBNativePackageName>
<TileDBNativePackageVersion>[2.30.0,2.31.0)</TileDBNativePackageVersion>
<TileDBNativePackageVersion>2.30.0</TileDBNativePackageVersion>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The current change pins the TileDB.Native package version to exactly 2.30.0. This contradicts the pull request's stated goal to "remove [the] upper bound" and "enable faster acquisition of new TileDB.Native versions". Pinning the version will prevent consumers from automatically picking up new releases.

To correctly remove the upper bound and allow any new version starting from 2.30.0, you should use the NuGet version range [2.30.0,).

    <TileDBNativePackageVersion>[2.30.0,)</TileDBNativePackageVersion>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant