-
Notifications
You must be signed in to change notification settings - Fork 5
Remove upper bound on TileDB.Native package dependency.
#604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @teo-tsirpanis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the dependency management for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to remove the upper version bound for the TileDB.Native package dependency to allow for faster adoption of new native library versions. However, the current change pins the dependency to the exact version 2.30.0, which is contrary to the intended goal. My review includes a critical comment with a suggested fix to use a floating version range [2.30.0,), which correctly removes the upper bound and will allow consumers to use any version from 2.30.0 onwards.
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | ||
| <TileDBNativePackageName>TileDB.Native</TileDBNativePackageName> | ||
| <TileDBNativePackageVersion>[2.30.0,2.31.0)</TileDBNativePackageVersion> | ||
| <TileDBNativePackageVersion>2.30.0</TileDBNativePackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current change pins the TileDB.Native package version to exactly 2.30.0. This contradicts the pull request's stated goal to "remove [the] upper bound" and "enable faster acquisition of new TileDB.Native versions". Pinning the version will prevent consumers from automatically picking up new releases.
To correctly remove the upper bound and allow any new version starting from 2.30.0, you should use the NuGet version range [2.30.0,).
<TileDBNativePackageVersion>[2.30.0,)</TileDBNativePackageVersion>
Fixes CORE-441. This will enable faster acquisiotion of new
TileDB.Nativeversions, without needing to release a newTileDB.CSharpversion.