Skip to content

Remove upper bound on TileDB.Native package dependency. #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teo-tsirpanis wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Remove upper bound on TileDB.Native package dependency. #604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<TileDBNativePackageName>TileDB.Native</TileDBNativePackageName>
<TileDBNativePackageVersion>[2.30.0,2.31.0)</TileDBNativePackageVersion>
<TileDBNativePackageVersion>2.30.0</TileDBNativePackageVersion>
Copy link

@gemini-code-assist gemini-code-assist bot Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The current change pins the TileDB.Native package version to exactly 2.30.0. This contradicts the pull request's stated goal to "remove [the] upper bound" and "enable faster acquisition of new TileDB.Native versions". Pinning the version will prevent consumers from automatically picking up new releases.

To correctly remove the upper bound and allow any new version starting from 2.30.0, you should use the NuGet version range [2.30.0,).

    <TileDBNativePackageVersion>[2.30.0,)</TileDBNativePackageVersion>


<!-- The DevelopmentBuild property switches to the locally built native packages.
They have a different name to avoid publishing them by mistake, and to
Expand Down
Loading