Conversation
084a98b to
f16c7b1
Compare
8d42be4 to
2c099b5
Compare
a910556 to
f8b513b
Compare
bf0d8b2 to
ea64b59
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
3cdba1e to
7b73bc3
Compare
gfardell
left a comment
There was a problem hiding this comment.
I still have the same issue on windows and can't build locally without specifying my cmake generator and toolset. Let's discuss further in the dev meeting.
casperdcl
left a comment
There was a problem hiding this comment.
to avoid doubling the CI usage on master, we could just do one windows build per python version.
Yep, i think that's a good plan. On a tag I guess we can set the numpy versions we build and test with to cover the range at least? On a push to master potentially just one python version is sufficient? The full functionality is tested by the linux tests, and it gives us one nightly to use if we need. On a any branch push I'd be tempted to drop to one linux version only, cpu and gpu? But maybe this is a bigger discussion. |
- fix: test correct numpy version with `--extra-deps numpy=x.x` instead of `--numpy=x.x` (fixes #2156) - fix: collect distributions in one job for upload & reindex (fixes #1918) - optimise + share one build (per OS/Python version) across multiple numpy versions + per PR: min py/np version, ubuntu + `master`: min & max py/np, all OS + `tag` or `workflow_dispatch`: all versions, all OS
- fix: test correct numpy version with `--extra-deps numpy=x.x` instead of `--numpy=x.x` (fixes #2156) - fix: collect distributions in one job for upload & reindex (fixes #1918) - optimise + share one build (per OS/Python version) across multiple numpy versions + per PR: min py/np version, ubuntu + `master`: min & max py/np, all OS + `tag` or `workflow_dispatch`: all versions, all OS
astra-toolboxtests are CPU-only on GHA native runnersconda-verifyto all buildsfollow-up later
recipe/conda_build_config.yamlin favour of CI matrixPR: [min], master: [min, max], tag: [min, ..., max]versions?)links
testing
/CC @gfardell @lauramurgatroyd @paskino
download art[ie]fact
cil-package-windows-py3.12-np1.26from the CI & unzip it, then: