Skip to content

CI: windows conda build & release#1918

Merged
casperdcl merged 5 commits intomasterfrom
gha-win
Aug 13, 2025
Merged

CI: windows conda build & release#1918
casperdcl merged 5 commits intomasterfrom
gha-win

Conversation

@casperdcl
Copy link
Member

@casperdcl casperdcl commented Aug 30, 2024

  • conda build windows matrix
    • fix msvc-python-cmake interoperability
    • fix tests (increase astra CPU 2D cone tolerance)
    • add release logic
  • ensure astra-toolbox tests are CPU-only on GHA native runners
  • add conda-verify to all builds

follow-up later

links

testing

/CC @gfardell @lauramurgatroyd @paskino

download art[ie]fact cil-package-windows-py3.12-np1.26 from the CI & unzip it, then:

set TESTS_FORCE_GPU=1
conda install cil-24.3.0-py312h*.tar.bz2
python -m unittest discover -v -s Wrappers/Python/test -k tigre -k TIGRE -k astra -k ASTRA -k Astra -k gpu -k GPU

@casperdcl casperdcl self-assigned this Aug 30, 2024
@casperdcl casperdcl changed the base branch from gha-conda-upload to master August 30, 2024 10:02
This was referenced Aug 30, 2024
@casperdcl casperdcl force-pushed the gha-win branch 5 times, most recently from 084a98b to f16c7b1 Compare August 30, 2024 10:27
@casperdcl casperdcl force-pushed the gha-win branch 3 times, most recently from 8d42be4 to 2c099b5 Compare August 30, 2024 12:52
@casperdcl casperdcl force-pushed the master branch 4 times, most recently from a910556 to f8b513b Compare September 2, 2024 13:11
@casperdcl casperdcl force-pushed the gha-win branch 7 times, most recently from bf0d8b2 to ea64b59 Compare September 26, 2024 23:58
@paskino

This comment was marked as resolved.

@gfardell

This comment was marked as resolved.

@casperdcl casperdcl mentioned this pull request Nov 7, 2024
8 tasks
@casperdcl casperdcl force-pushed the gha-win branch 3 times, most recently from 3cdba1e to 7b73bc3 Compare August 11, 2025 14:05
@casperdcl casperdcl added enhancement New feature or request Waiting for review and removed Work In Progress enhancement New feature or request labels Aug 11, 2025
@casperdcl casperdcl moved this from In Progress to Priority review in CIL work Aug 11, 2025
@casperdcl casperdcl marked this pull request as ready for review August 11, 2025 14:14
@casperdcl casperdcl requested a review from a team as a code owner August 11, 2025 14:14
@casperdcl casperdcl added this to the v25.0.0 milestone Aug 11, 2025
@casperdcl casperdcl changed the title CI: windows conda build CI: windows conda build & release Aug 11, 2025
Copy link
Member

@gfardell gfardell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have the same issue on windows and can't build locally without specifying my cmake generator and toolset. Let's discuss further in the dev meeting.

Copy link
Member Author

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to avoid doubling the CI usage on master, we could just do one windows build per python version.

@gfardell
Copy link
Member

to avoid doubling the CI usage on master, we could just do one windows build per python version.

Yep, i think that's a good plan. On a tag I guess we can set the numpy versions we build and test with to cover the range at least?

On a push to master potentially just one python version is sufficient? The full functionality is tested by the linux tests, and it gives us one nightly to use if we need.

On a any branch push I'd be tempted to drop to one linux version only, cpu and gpu? But maybe this is a bigger discussion.

@casperdcl casperdcl merged commit 7db9272 into master Aug 13, 2025
11 checks passed
@casperdcl casperdcl deleted the gha-win branch August 13, 2025 10:28
@github-project-automation github-project-automation bot moved this from Priority review to Done in CIL work Aug 13, 2025
casperdcl added a commit that referenced this pull request Aug 14, 2025
- fix: test correct numpy version with `--extra-deps numpy=x.x` instead of `--numpy=x.x` (fixes #2156)
- fix: collect distributions in one job for upload & reindex (fixes #1918)
- optimise
  + share one build (per OS/Python version) across multiple numpy versions
  + per PR: min py/np version, ubuntu
  + `master`: min & max py/np, all OS
  + `tag` or `workflow_dispatch`: all versions, all OS
casperdcl added a commit that referenced this pull request Aug 14, 2025
- fix: test correct numpy version with `--extra-deps numpy=x.x` instead of `--numpy=x.x` (fixes #2156)
- fix: collect distributions in one job for upload & reindex (fixes #1918)
- optimise
  + share one build (per OS/Python version) across multiple numpy versions
  + per PR: min py/np version, ubuntu
  + `master`: min & max py/np, all OS
  + `tag` or `workflow_dispatch`: all versions, all OS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants