SIM RFC: AI selector interface #3568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| command = ManualGCCommand(manual_command=Command(type=command, for_team=team)) | ||
| self.proto_unix_io.send_proto(ManualGCCommand, command) | ||
|
|
||
| def __find_backend_options(self) -> list[str]: |
Contributor
There was a problem hiding this comment.
(wait uh i think find_backend_options might have been part of my issue lmao, tysm)
(i think my version checks for if the file is executable as well, i'll integrate it once i create a pr)
(oops sorry this wasn't meant to be a review, not sure why it is rn)
Contributor
|
Code looks good! Can you attach a screenshot of how does it look like? That would be great. |
Andrewyx
requested changes
Jan 19, 2026
Contributor
Andrewyx
left a comment
Andrewyx
left a comment
There was a problem hiding this comment.
Looks good in the sim! Left some small comments
src/software/thunderscope/gl/widgets/backend_selection_dialog.py
Outdated
Show resolved
Hide resolved
src/software/thunderscope/gl/widgets/backend_selection_dialog.py
Outdated
Show resolved
Hide resolved
src/software/thunderscope/gl/widgets/backend_selection_dialog.py
Outdated
Show resolved
Hide resolved
src/software/thunderscope/gl/widgets/gl_gamecontroller_toolbar.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new modal for selecting the runtimes used by blue and yellow teams in Thunderscope. The modal allows users to choose from a list of installed runtimes (from #3569) and commits the selection via a callback (also from #3569).
Testing Done
I passed in test values as menu options and wrote print statements in the callback. The values printed as expected.
Resolved Issues
#3556
Length Justification and Key Files to Review
N/A
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue