Refactor Dialog and Popup to remove jquery#945
Conversation
dmfalke
left a comment
There was a problem hiding this comment.
I think this looks great. However, I think we need to make the component draggable by default. There are some places where we definitely want the dialog to be draggable, even though we don't specify it. For example, the step details dialog in the strategy panel.
If you have the time and energy, you could find all of the places where we use the Dialog component and we can determine if each one should be draggable. Otherwise, let's just make it the default behavior.
I opted for the simpler solution of defaulting to true. That's essentially how it was working before, though now I suppose we'll needlessly be passing |
Works to resolve the second
wdk-clienttask from #899:Overlays/Popup: used only in Dialog, but Dialog is used widelyIt's worth noting that the
draggableprop passed toDialogwas being ignored. Whether or notdraggablewas passed intoDialogand thus down toPopup, it was always rendered as draggable. With these changes, I'm listening to the draggable prop and only rendering a draggableDialogwhen it's explicitly passed in.