js-tokens: use preload source code #228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kmiller68
reviewed
Nov 12, 2025
| jsTokensSourceCode = ""; | ||
|
|
||
| async init() { | ||
| this.jsTokensSourceCode = await JetStream.getString(JetStream.preload.SOURCE_CODE); |
Contributor
There was a problem hiding this comment.
Can we eval or dynamically import this rather than have two copies of the source?
Contributor
Author
There was a problem hiding this comment.
rewrote it to reuse js-tokens.js as SOURCE_CODE (requires us to modify the EXPECTED_TOKEN_COUNT whenever we touch it, but thats probably ok)
Contributor
Author
|
Pending on #242 and additional refactorings to support loading a file and preload with the same URL (currently this is silently ignored) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function.toString is not necessarily returning the full function body per spec.
We can inject the sources with the preload mechanism which is well defined and more flexible.