Skip to content

js-tokens: use preload source code #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camillobruni wants to merge 11 commits into
base: main
Choose a base branch
from
Open

js-tokens: use preload source code #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2a65293
inject source code from the outside
camillobruni Oct 27, 2025
2946337
cleanup
camillobruni Oct 27, 2025
8ad7b0f
fix token count
camillobruni Oct 27, 2025
1b7dce5
fix tokens
camillobruni Oct 27, 2025
d2b3c88
fix
camillobruni Oct 27, 2025
b6d1cdf
input
camillobruni Oct 27, 2025
796f2a8
Merge branch 'main' into 2025-10-27_js-tokens
camillobruni Oct 28, 2025
6e82cba
fix tokens inpu
camillobruni Oct 28, 2025
3800e92
Merge branch 'main' into 2025-10-27_js-tokens
camillobruni Oct 30, 2025
7f77e99
Merge branch 'main' into 2025-10-27_js-tokens
camillobruni Dec 10, 2025
7e4b765
update
camillobruni Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion JetStreamDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2376,11 +2376,14 @@ let BENCHMARKS = [
],
tags: ["default", "js", "Generators"],
}),
new DefaultBenchmark({
new AsyncBenchmark({
name: "js-tokens",
files: [
"./generators/js-tokens.js",
],
preload: {
SOURCE_CODE: "./generators/js-tokens.js",
},
tags: ["default", "js", "Generators"],
}),
new DefaultBenchmark({
Expand Down
16 changes: 12 additions & 4 deletions generators/js-tokens.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,6 @@ function jsTokensWrapperFunction() {
};
};

const jsTokensSourceCode = jsTokensWrapperFunction.toString();
const jsxSourceCode = `

function Comment(props) {
Expand All @@ -437,11 +436,20 @@ function Comment(props) {
const jsTokens = jsTokensWrapperFunction();

class Benchmark {
EXPECTED_TOKEN_COUNT = 121975;

tokenCount = 0;
jsTokensSourceCode = "";

async init() {
this.jsTokensSourceCode = await JetStream.getString(JetStream.preload.SOURCE_CODE);
Copy link
Contributor

@kmiller68 kmiller68 Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we eval or dynamically import this rather than have two copies of the source?

Copy link
Contributor Author

@camillobruni camillobruni Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrote it to reuse js-tokens.js as SOURCE_CODE (requires us to modify the EXPECTED_TOKEN_COUNT whenever we touch it, but thats probably ok)

}

runIteration() {
this.tokenCount = 0;

for (var i = 0; i < 25; i++) {
for (const token of jsTokens(jsTokensSourceCode))
for (const token of jsTokens(this.jsTokensSourceCode))
this.tokenCount++;
}

Expand All @@ -452,7 +460,7 @@ class Benchmark {
}

validate(iterations) {
if (this.tokenCount !== 113975)
throw new Error(`this.tokenCount of ${this.tokenCount} is invalid!`);
if (this.tokenCount !== this.EXPECTED_TOKEN_COUNT)
throw new Error(`Expected this.tokenCount of ${this.EXPECTED_TOKEN_COUNT}, but got ${this.tokenCount}!`);
}
}
Loading