-
Notifications
You must be signed in to change notification settings - Fork 1.6k
infinite loop test #6064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infinite loop test #6064
Conversation
2227d15 to
dda7adc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ripple/wasmi-host-functions #6064 +/- ##
===========================================================
Coverage 79.6% 79.6%
===========================================================
Files 845 845
Lines 73314 73314
Branches 8363 8360 -3
===========================================================
+ Hits 58361 58368 +7
+ Misses 14953 14946 -7 🚀 New features to boost your workflow:
|
dda7adc to
182e542
Compare
182e542 to
ea4d668
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a test to verify that WebAssembly infinite loops are properly detected and handled. The test expects infinite loop execution to be caught and return a tecFAILED_PROCESSING error efficiently.
- Adds
testInfiniteLoop()test function with embedded WASM bytecode containing an infinite loop - Integrates the new test into the test suite execution
- Tests that infinite loops fail appropriately with
tecFAILED_PROCESSINGerror code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f57f67a
into
XRPLF:ripple/wasmi-host-functions
High Level Overview of Change
This PR adds a simple infinite loop test. It passes in negligible time.
Note: this PR shouldn't be merged until the Wasmi changes are added to the base branch. This test has been verified locally against that branch, but CI isn't passing yet.
Context of Change
Testing
Type of Change
API Impact
N/A
Test Plan
Added a test. It passed efficiently.