Skip to content

Conversation

@ximinez
Copy link
Collaborator

@ximinez ximinez commented Jan 23, 2026

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@ximinez ximinez changed the title Revert "Bugfix: Adds graceful peer disconnection (#5669)" (#5855) DRAFT: Can I use an int64 range? Jan 23, 2026
@ximinez ximinez changed the base branch from develop to release-3.1 January 23, 2026 20:57
@ximinez ximinez force-pushed the ximinez/number-maxint-range branch from 3094798 to c01bfb2 Compare January 23, 2026 21:01
@ximinez ximinez added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Jan 26, 2026
@ximinez ximinez force-pushed the ximinez/number-maxint-range branch from 3934fdb to b0d8b61 Compare January 27, 2026 02:12
@ximinez ximinez added DraftRunCI Normally CI does not run on draft PRs. This opts in. and removed DraftRunCI Normally CI does not run on draft PRs. This opts in. labels Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 98.62069% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (ximinez/staging-3.1@1392432). Learn more about missing BASE report.

Files with missing lines Patch % Lines
include/xrpl/basics/Number.h 96.2% 1 Missing ⚠️
src/libxrpl/basics/Number.cpp 99.2% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##             ximinez/staging-3.1   #6275   +/-   ##
=====================================================
  Coverage                       ?   79.4%           
=====================================================
  Files                          ?     839           
  Lines                          ?   71733           
  Branches                       ?    8258           
=====================================================
  Hits                           ?   56926           
  Misses                         ?   14807           
  Partials                       ?       0           
Files with missing lines Coverage Δ
include/xrpl/protocol/Protocol.h 100.0% <ø> (ø)
include/xrpl/protocol/STAmount.h 96.2% <100.0%> (ø)
include/xrpl/protocol/SystemParameters.h 100.0% <ø> (ø)
include/xrpl/basics/Number.h 98.1% <96.2%> (ø)
src/libxrpl/basics/Number.cpp 98.6% <99.2%> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- That makes minMantissa 2^63/10+1.
- Simplifies many of the existing operations, and removes the need for
  the accessors (mantissa() & exponent()) to do any math.
- Simplify shiftExponent().
- Clean up to_string() to prevent integers from including "e0".
- Fix root() and root2() computations by ensuring the mantissas have
  a consistent length.
@ximinez ximinez force-pushed the ximinez/number-maxint-range branch from 7275749 to 6fcb32e Compare January 27, 2026 23:22
@ximinez ximinez changed the base branch from release-3.1 to ximinez/staging-3.1 January 27, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DraftRunCI Normally CI does not run on draft PRs. This opts in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants