[bug] fix viewer crash after few seconds while streaming data from optitrack#33
Open
hoangminhtoan wants to merge 2 commits intoYanjieZe:masterfrom
Open
[bug] fix viewer crash after few seconds while streaming data from optitrack#33hoangminhtoan wants to merge 2 commits intoYanjieZe:masterfrom
hoangminhtoan wants to merge 2 commits intoYanjieZe:masterfrom
Conversation
Owner
|
Thank you for the pr. Would you mind simplifying the change a bit to handle this error? The motivation for this motion viewer is to simply visualization motion, assuming you have the right streaming data. |
Author
|
Hi, Thanks for the feedback! I'll simplify the implementation to focus on the core error handling you mentioned. Let me refactor this to: The key changes I've made:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug when the viewer crashes after a few seconds while receiving FBX data from the Optitrack.