fix: hk-* actions migrated to using requirements file#1116
Conversation
|
Successful run in : https://github.com/ansys/pyansys-geometry/actions/runs/21132251692 |
…ions into fix/hk-package-actions
I think it should be left exposed exactly for the reason you mentioned i.e. fixing convenience. Exposing the python version (and having a default value) in actions where python scripting is used has also been a convenient way to quickly identify such actions (especially during general minimum version bumps). There can be other convenience I might not be thinking about atm too. But I don't have strong opinions either (but mine is definitely stronger than yours 😉). |
There are numerous ways the action could break. Only a small number of them are fixed by changing the Python version. To me, the Python version used is an internal of the action, and shouldn't be exposed. The downside of having a user-overridden Python version is that:
|
|
In the case of Also, the dependency changes align with the effort we discussed on pinning dependencies and the on going POC (stopped ftm) #991 |
|
Let me remove it in that case. I'll pin it to Python 3.13 |
|
Successful run in https://github.com/ansys/pyansys-geometry/actions/runs/21172889164 |
|
Can I get a review and final approval @ansys/pyansys-core if you agree with this? |
AlejandroFernandezLuces
left a comment
There was a problem hiding this comment.
LGTM, minor comments
Co-authored-by: Alex Fernandez <21alex295@gmail.com>
|
The following people have not signed the Contributors License Agreement (CLA):
Read the CLA in the link above and sign it by clicking the link below: You will receive a confirmation as soon as your signature is captured. |
|
I'll be merging then thankyou all |
Closes #1115
@ansys/pyansys-core - should we consider removing the Python version for actions such as this one? This was proposed by @greschd in #1115 as well. I haven't got a strong opinion on this: I agree with @greschd that it's not needed and users shouldn't have to worry about it, but it also provided a way for a quick fix in case somebody needed to "solve" this issue right away.