Skip to content

fix: hk-* actions migrated to using requirements file#1116

Merged
RobPasMue merged 8 commits intomainfrom
fix/hk-package-actions
Jan 23, 2026
Merged

fix: hk-* actions migrated to using requirements file#1116
RobPasMue merged 8 commits intomainfrom
fix/hk-package-actions

Conversation

@RobPasMue
Copy link
Member

Closes #1115

@ansys/pyansys-core - should we consider removing the Python version for actions such as this one? This was proposed by @greschd in #1115 as well. I haven't got a strong opinion on this: I agree with @greschd that it's not needed and users shouldn't have to worry about it, but it also provided a way for a quick fix in case somebody needed to "solve" this issue right away.

@RobPasMue RobPasMue requested a review from a team as a code owner January 19, 2026 09:30
@RobPasMue RobPasMue self-assigned this Jan 19, 2026
@github-actions github-actions bot added the fix Pull requests related to resolving problems or errors label Jan 19, 2026
@RobPasMue
Copy link
Member Author

@RobPasMue RobPasMue requested a review from greschd January 19, 2026 09:32
@RobPasMue
Copy link
Member Author

@moe-ad
Copy link
Contributor

moe-ad commented Jan 19, 2026

Closes #1115

@ansys/pyansys-core - should we consider removing the Python version for actions such as this one? This was proposed by @greschd in #1115 as well. I haven't got a strong opinion on this: I agree with @greschd that it's not needed and users shouldn't have to worry about it, but it also provided a way for a quick fix in case somebody needed to "solve" this issue right away.

I think it should be left exposed exactly for the reason you mentioned i.e. fixing convenience. Exposing the python version (and having a default value) in actions where python scripting is used has also been a convenient way to quickly identify such actions (especially during general minimum version bumps). There can be other convenience I might not be thinking about atm too.

But I don't have strong opinions either (but mine is definitely stronger than yours 😉).

@greschd
Copy link
Member

greschd commented Jan 19, 2026

I think it should be left exposed exactly for the reason you mentioned i.e. fixing convenience.

There are numerous ways the action could break. Only a small number of them are fixed by changing the Python version.

To me, the Python version used is an internal of the action, and shouldn't be exposed.

The downside of having a user-overridden Python version is that:

  • it's less well-tested compared to the default version; this could hide subtle bugs
  • it increases maintenance overhead on the actions repository if it needs to implicitly support multiple Python versions / dropping Python versions means a breaking change
  • inevitably, the user will eventually need to update or remove the override again

@SMoraisAnsys
Copy link
Contributor

SMoraisAnsys commented Jan 20, 2026

In the case of hk-* actions, I don't mind removing the python version used and would advocate to remove it on other actions as long as there is no direct correlation between the action and the repo it is used on. For example, testing, doc build, ... require interaction with the project and it's dependencies. So, no modifications on those :)

Also, the dependency changes align with the effort we discussed on pinning dependencies and the on going POC (stopped ftm) #991

@RobPasMue
Copy link
Member Author

Let me remove it in that case. I'll pin it to Python 3.13

@RobPasMue
Copy link
Member Author

@RobPasMue RobPasMue requested a review from greschd January 23, 2026 07:13
@RobPasMue
Copy link
Member Author

Can I get a review and final approval @ansys/pyansys-core if you agree with this?

Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

Co-authored-by: Alex Fernandez <21alex295@gmail.com>
@ansys-cla-bot
Copy link

ansys-cla-bot bot commented Jan 23, 2026

The following people have not signed the Contributors License Agreement (CLA):

  • @<21alex295

Read the CLA in the link above and sign it by clicking the link below:

You will receive a confirmation as soon as your signature is captured.

@RobPasMue RobPasMue merged commit ddb11a2 into main Jan 23, 2026
64 of 67 checks passed
@RobPasMue RobPasMue deleted the fix/hk-package-actions branch January 23, 2026 09:31
@RobPasMue
Copy link
Member Author

I'll be merging then thankyou all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Pull requests related to resolving problems or errors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hk-package-clean-untagged fails with SyntaxError

8 participants