MINOR: Cleanup Trogdor Module

[sjhajharia]

Now that Kafka support Java 17, this PR makes some changes in trogdor
module. The changes mostly include:

• Collections.emptyList(), Collections.singletonList() and
  Arrays.asList() are replaced with List.of()
• Collections.emptyMap() and Collections.singletonMap() are replaced
  with Map.of()
• Collections.singleton() is replaced with Set.of()

Some minor cleanups around use of enhanced switch blocks and conversion
of classes to record classes.

Reviewers: Ken Huang s7133700@gmail.com, Vincent Jiang
vpotucek@me.com, Chia-Ping Tsai chia7712@gmail.com

[m1a2st]

Thanks @sjhajharia for this patch, left some comments

[sjhajharia]

Thank you @m1a2st and @Pankraz76 for the reviews. I have addressed them.
Requesting a re-review when possible.
TIA!

[Pankraz76]

nicely done, thanks. Until taken care by plugin it can happen anytime leaving this task kind of open. Offering to apply thins kind of conventions via rewrite.

• https://docs.openrewrite.org/recipes/staticanalysis/missingoverrideannotation

[sjhajharia]

Adding @chia7712 for review
TIA.

[chia7712]

the name taskId is same as the method name, so are those annotations really necessary?

[Pankraz76]

considering Override kind of best practice, it should not do any harm.

Can not tell anything about JsonProperty, except of assuming its needed by the business case, therefore covered by some test, or it can be removed/challenged.

[sjhajharia]

Hey @chia7712 , I agree, both of the annotations are unnexcessary. Dropped them.
Pls re-review. TIA!

[Pankraz76]

Thanks for the inspiration. False positive(s) should be covered as well.

• MissingOverrideAnnotation: removeFalsyOverrideAnnotation openrewrite/rewrite-static-analysis#684

[chia7712]

@sjhajharia thanks for this patch. I have left a couple of comments.

[chia7712]

Why is it being sorted?

[sjhajharia]

This was done because TopicsSpecTest.testPartitionNumbers became flaky after the changes. Upon further consideration, I re-did the test rather than add a complexity here.

[sjhajharia]

Thank you @chia7712 for the review. I have addressed the same.