MissingOverrideAnnotation: removeFalsyOverrideAnnotation

[Pankraz76]

What's changed?

• https://docs.openrewrite.org/recipes/staticanalysis/missingoverrideannotation

It seems the rules does not cover false positives as well. Should this be included?

What's your motivation?

are those annotations really necessary

• MINOR: Cleanup Trogdor Module apache/kafka#20214
  • MINOR: Cleanup Trogdor Module apache/kafka#20214 (comment)

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[Pankraz76]

is this any good? @timtebeek

fell free to tune and complete @iddeepak

[github-actions]

Some suggestions could not be made:

• src/main/java/org/openrewrite/staticanalysis/MissingOverrideAnnotation.java
  • lines 33-33

[github-actions]

Suggested change

	import lombok.var;
	import org.jspecify.annotations.Nullable;
	import org.jspecify.annotations.Nullable;

[github-actions]

Suggested change

	""")
	"""
	)

[github-actions]

Suggested change

	""")
	"""
	)

[github-actions]

Suggested change

	""")
	"""
	)

[github-actions]

Suggested change

	""")
	);
	"""
	)
	@Test

[github-actions]

Suggested change

	""")
	"""
	)

[github-actions]

Suggested change

	""")
	"""
	)

[timtebeek]

On my machine this already fails to compile; what would be the reason then to add this to a recipe that aims to add missing override annotations?

I'd lean towards closing this effort, as it's quite unlikely, and misplaced / unexpected in this recipe.

[Pankraz76]

aims to add missing override annotations

What about changing the scope to check for corrupt (missing/falsy) override annotations.

We could create a new one like CheckforFalsyOverrideAnnotation but that would impose configuration burden on customer instead of applying convention. Once could argue that every recipe, could check for false negatives as well.

As if not, gonna have to copy potentially every recipe 1 times to check for false negative as well.

[timtebeek]

As indicated above, a misplaced Override annotation already does not compile on my machine; have you seen any number of example of that in the wild at all that warrant an automated remediation? If there's a convincing case we can reopen, but for now I just don't see it.

[Pankraz76]

this was my intention:

apache/kafka@2575f47